This Bugzilla instance is deprecated, and most Eclipse projects now use GitHub or Eclipse GitLab. Please see the deprecation plan for details.
Bug 293712 - Workbench hangs after adding extension element in WSDL Editor
Summary: Workbench hangs after adding extension element in WSDL Editor
Status: CLOSED FIXED
Alias: None
Product: WTP Webservices
Classification: WebTools
Component: wst.wsdl (show other bugs)
Version: 3.2   Edit
Hardware: PC Windows XP
: P3 critical (vote)
Target Milestone: 3.2 M3   Edit
Assignee: Valentin Baciu CLA
QA Contact: Valentin Baciu CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-10-29 13:59 EDT by Keith Chong CLA
Modified: 2009-10-30 12:19 EDT (History)
0 users

See Also:

Attachments
Patch (1.43 KB, patch)
2009-10-29 14:51 EDT, Valentin Baciu CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Chong CLA 2009-10-29 13:59:43 EDT 
Steps to reproduce:

1.Import the XML Examples: New -> Example ... -> Editing and validating XML files 
2.Open XMLExamples/PhoneBanking/PhoneBanking.wsdl and make sure you're in the design view 
3.In the Outline view, right click Bindings -> PhoneBankingSOAP and select Show properties 
4.Click on the Extensions tab 
5.Verify that you can see the soap:binding extension 
6.Click Add... 
7.Select HTTP and then select binding and click OK 

--> Hangs
Comment 1 Keith Chong CLA 2009-10-29 14:03:06 EDT 
Changing severity to critical.
Comment 2 Valentin Baciu CLA 2009-10-29 14:48:02 EDT 
The hang is due to an infinite loop in org.eclipse.wst.wsdl.ui.internal.commands.AddExtensionElementCommand.addNamespaceDeclarationIfRequired(Element, String, String) 

The root cause is a change in the SSE DOM behaviour, see bug 272378. We have a larger patch ready to react to that in the WSDL tools with bug 287705 but we've missed applying it in time for M3.

I will attach a targetted fix to fix just this infinite loop.
Comment 3 Valentin Baciu CLA 2009-10-29 14:51:34 EDT 
Created attachment 150863 [details]
Patch
Comment 4 Valentin Baciu CLA 2009-10-29 15:23:44 EDT 
Patch committed and released to WTP 3.2 builds > v200910291925 UTC
Comment 5 Keith Chong CLA 2009-10-30 12:19:47 EDT 
Verified in I-3.2.0-20091029192916