Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 293690 - Cells/records cannot be copied/cut and pasted between datapools.
Summary: Cells/records cannot be copied/cut and pasted between datapools.
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: TPTP (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P2 major (vote)
Target Milestone: ---   Edit
Assignee: Paul Slauenwhite CLA
QA Contact: Kathy Chan CLA
URL:
Whiteboard:
Keywords:
Depends on: 155428 243366 252959
Blocks:
  Show dependency tree
 
Reported: 2009-10-29 12:45 EDT by Paul Slauenwhite CLA
Modified: 2016-05-05 10:36 EDT (History)
1 user (show)

See Also:

Attachments
Patch. (29.80 KB, patch)
2010-04-01 13:59 EDT, Paul Slauenwhite CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Paul Slauenwhite CLA 2009-10-29 12:45:50 EDT 
Cells/records cannot be copied/cut and pasted between datapools.

Steps to reporduce:

1) Create two datapools with one or more variables and records.
2) Copy a cell from one datapool and paste it in the other datapool.
3) Note the cell is not pasted and the original datapool's dirty bit is set.

The same applies for records.
Comment 1 Paul Slauenwhite CLA 2009-10-29 12:59:43 EDT 
Requires support for pasting records with one or more encrypted between datapools.

Requires new tests.
Comment 2 Paul Slauenwhite CLA 2009-12-14 15:02:58 EST 
Deferring to TPTP 4.7.0.
Comment 3 Paul Slauenwhite CLA 2010-03-09 15:04:32 EST 
No longer required by the consuming product.
Comment 4 Paul Slauenwhite CLA 2010-03-31 22:22:44 EDT 
In addition, the Delete and Select All actions do not work when two or more datapools are open at the same time.
Comment 5 Paul Slauenwhite CLA 2010-04-01 13:37:49 EDT 
This was caused by a couple of the problems:

1) The singleton instance of org.eclipse.hyades.test.ui.datapool.internal.control.DatapoolActionHandlerListener was used create the cut/copy/paste/delete/select all actions in the org.eclipse.hyades.test.ui.datapool.internal.control.DatapoolMenuManager.  Since the menu is associated with only datapool table, the actions were not configured to use the correct datapool table.

2) The singleton instance of org.eclipse.hyades.test.ui.datapool.internal.control.DatapoolClipboard was used by each org.eclipse.hyades.test.ui.datapool.internal.control.DatapoolTable but the record(s)/cell were datapool table-specific.  Since the org.eclipse.hyades.test.ui.datapool.internal.control.DatapoolClipboard has routinely caused issues for datapool cut/copy/paste stemming from a poor implementation, I rewrote the class to be a cleaner/lightweight wrapper around the org.eclipse.swt.dnd.Clipboard class for datapool cell, record, and string data.  The new implementations uses org.eclipse.swt.dnd.Clipboard as the persistence mechanism instead of transient instance variables.

Refactored several test cases in /org.eclipse.hyades.test.ui.datapool.tests/manual/datapool/Test.UI.DatapoolEditor_editing.testsuite to cover these scenarios.
Comment 6 Paul Slauenwhite CLA 2010-04-01 13:59:22 EDT 
Created attachment 163655 [details]
Patch.
Comment 7 Paul Slauenwhite CLA 2010-06-23 13:27:30 EDT 
Verified in TPTP-4.7.0RC4-201006081927.

Closing.