Community
Participate
Working Groups
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; de; rv:1.9.1.3) Gecko/20090824 Firefox/3.5.3 Build Identifier: HEAD In text editors the Find/Replace feature is useful for in-document navigation (Find) and powerful for editing (Replace). Vex is also a kind of text editor but does not yet support Find/Replace. Especially in large documents Find/Replace could make navigation faster and replacing less error-prone. Goal: In Vex Ctrl+F should bring up the Find/Replace dialog with the same functionality as in text editors. Reproducible: Always
Created attachment 150443 [details] JUnit tests and implementation - please review! Limitation: Scope 'Selected lines' is not supported (unclear: what's the meaning of 'Selected lines' in Vex). Unfortunately, this option can not be disabled.
Unfortunately, I'll have to send this through IP review due to the size. I'll get this started today.
(In reply to comment #2) Thx! Only out of interest: What would be the size limit? Do JavaDoc and JUnit count?
(In reply to comment #3) > (In reply to comment #2) > Thx! > Only out of interest: What would be the size limit? Do JavaDoc and JUnit count? 250 lines of "code". Even with out java doc and comments, the contribution exceeded that limit. As a committer you don't have to worry about it, I just have to have IP review contributions from the outside greater than 250 lines of code.
(In reply to comment #3) > (In reply to comment #2) > Thx! > Only out of interest: What would be the size limit? Do JavaDoc and JUnit count? Eclipse IP has some basic questions: 1. Did e authored 100% of the content 2. Does he have the rights to donate the content to Eclipse 3. Does he contribute the content under the EPL
(In reply to comment #5) > Eclipse IP has some basic questions: > > 1. Did he authored 100% of the content Yes. (TDD aware: Code grew with each new test.) > 2. Does he have the rights to donate the content to Eclipse Yes. (I coded this at home as a private person.) > 3. Does he contribute the content under the EPL Yes. (The new files contain the EPL statement.)
IP approved the submission. So I'll work on applying the patch today. Will post here once it is in place.
Okay, I have one unit test in this that is failing. FindWholeWord. It's matching up on the first xxx in [xxx xxx? xxx] instead of the last xxx. What I'll do is comment out that one test, add this to the existing VEX test suite, and check in the contribution. You can then check out the code and see if you can figure out what is happening with that test. Then just attach a patch for that test failure fix.
Created attachment 151014 [details] Test failure fix and actions defined for Find Next (Ctrl+K) and Find Previous (Ctrl+Shift+K) (In reply to comment #8) Thank you for applying the patch! The test failure was an encoding problem. In the test I used German umlauts. Why not set encoding per project and check-in '.settings/org.eclipse.core.resources.prefs' to prevent me making such mistakes? ;-)
(In reply to comment #9) > Created an attachment (id=151014) [details] > Test failure fix and actions defined for Find Next (Ctrl+K) and Find Previous > (Ctrl+Shift+K) > > (In reply to comment #8) > Thank you for applying the patch! > The test failure was an encoding problem. In the test I used German umlauts. > Why not set encoding per project and check-in > '.settings/org.eclipse.core.resources.prefs' to prevent me making such > mistakes? ;-) Probably should make the default encoding UTF-8 that way it covers pretty much everything.
Thanks, patch applied.
Closing resolved bugs.
Moved to Mylyn Docs Vex.
