Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 292765 - [content assist] JSP content assist is duplicating suggestions for custom libraries
Summary: [content assist] JSP content assist is duplicating suggestions for custom lib...
Status: CLOSED FIXED
Alias: None
Product: WTP Source Editing
Classification: WebTools
Component: jst.jsp (show other bugs)
Version: 3.2   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 3.2 M4   Edit
Assignee: Ian Tewksbury CLA
QA Contact: Nitin Dahyabhai CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-10-20 09:17 EDT by Ian Tewksbury CLA
Modified: 2010-01-14 13:27 EST (History)
2 users (show)

See Also:
nsand.dev: review+

Attachments
Fix Patch (3.71 KB, patch)
2009-10-20 10:01 EDT, Ian Tewksbury CLA 		nsand.dev: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ian Tewksbury CLA 2009-10-20 09:17:38 EDT 
Unfortunately  Bug 291246 seems to have introduced duplication of suggestions for JSP custom library tags.  It appears to have something to do with child classes all calling their supper methods which add the completion proposals more then once.
Comment 1 Ian Tewksbury CLA 2009-10-20 10:01:30 EDT 
Created attachment 149972 [details]
Fix Patch

Fixes the duplication by updating the merge method to use a TreeSet sot that duplicates from all of the embedded processors are weeded out before returning the results.

This patch also fixes another boo boo made by Bug 291246 in that the 'else' of an 'else if' statement was accidentally removed.  This is because the preceding if was originally removed but then added back in and the 'else' of what became the 'if' was neglected when adding back the original if.  Confusing enough? :)
Comment 2 Nick Sandonato CLA 2009-11-10 11:29:06 EST 
Looks good. Thanks.
Comment 3 Ian Tewksbury CLA 2010-01-13 16:55:47 EST 
Verified in 3.2I-20100105_003934
Comment 4 Ian Tewksbury CLA 2010-01-14 13:27:30 EST 
see comment #3