Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 292465 - Terminate and Remove action was broken by 284363
Summary: Terminate and Remove action was broken by 284363
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Debug (show other bugs)
Version: 3.6   Edit
Hardware: PC Windows Vista
: P3 normal (vote)
Target Milestone: 3.6 M3   Edit
Assignee: Pawel Piech CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-10-15 16:59 EDT by John Cortell CLA
Modified: 2009-10-15 17:40 EDT (History)
1 user (show)

See Also:

Attachments
fix (1.13 KB, patch)
2009-10-15 17:24 EDT, John Cortell CLA 		john.cortell: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description John Cortell CLA 2009-10-15 16:59:22 EDT 
This action is available from the context menu in the Debug view. As of 284363, it terminates the active debug context, but does not remove it from the Debug view. The use of an ICommandParticipant was removed, which is how action post-activity is now done in the Flexible Hierarchy architecture.

By the way, I'm still green on the retargetable action architecture, but it seems like there's some missing FH design in all this. The terminate action is hardcoded with standard debug model 'remove' logic; a custom model has no chance to override this logic.
Comment 1 John Cortell CLA 2009-10-15 17:24:08 EDT 
Created attachment 149687 [details]
fix

I see that what's missing is the overriding of that method that allows the action to hook in the post activity, being that ICommandParticipant was kept intentionally out of the API.
Comment 2 Pawel Piech CLA 2009-10-15 17:39:27 EDT 
Thanks John,  I apparently missed this in bug 284363 (I had only converted TerminateAndRelaunch).

I committed the fix.
Comment 3 Pawel Piech CLA 2009-10-15 17:40:09 EDT 
Marking verified.