Community
Participate
Working Groups
Created attachment 149364 [details] patch and icon files to enhance PTP 3.0 to support SLURM rms This enhancement includes a patch and some icon files to make CVS HEAD (and hopefully, the upcoming PTP 3.0) to support SLURM rms. This implementation includes some bug fixes from previous version for PTP 2.1, and reimplements some UI elements for PTP 3.0. This release supports node monitoring, job monitoring, (debug)job launch, and (debug)job control. Please read the README file included in the compressed package to apply the patch to CVS HEAD code.
Created attachment 149448 [details] Fixed newer version of the patch file This newer patch fixes some bugs in the previous patch file. Please replace the patch file in the previously submitted zip package with THIS patch file.
I, Jie Jiang, declare that I developed 100% of the attached code from scratch, and I have the rights to donate it to Eclipse, and I am willing to contribute the content under the terms of EPL.
This has now been approved, however I need you to make some changes and regenerate the whole patch (including images). Please use the "Team>Create Patch..." context menu to create the patch file, then add it to this bug. First, for copyright notices like the following, please change the text "NUDT school of computer - 605 staff room" to "Jie Jang, National University of Defense Technology". + # Copyright (c) 2008,2009 School of Computer Science,National University + # of Defense Technology,Changsha,China.All rights reserved. This program + # and the accompanying materials are made available under the terms of + # the Eclipse Public License v1.0 which accompanies this distribution, + # and is available at http://www.eclipse.org/legal/epl-v10.html + # Contributors: + # NUDT school of computer - 605 staff room Second, your patch modifies the JobAttributes and NodeAttributes classes. There is no need to do this. Instead, you should create your own classes (e.g. SLURMJobAttributes, SLURMNodeAttributes) in org.eclipse.ptp.slurm.core, then initialize your attributes in doCreateRuntimeSystem(): protected IRuntimeSystem doCreateRuntimeSystem() { AttributeDefinitionManager attrDefMgr = getAttributeDefinitionManager(); attrDefMgr.setAttributeDefinitions(SLURMJobAttributes.getDefaultAttributeDefinitions()); attrDefMgr.setAttributeDefinitions(SLURMNodeAttributes.getDefaultAttributeDefinitions()); ... } Third, you added your images to RMModelImages. You should provide your own SLURMModelImages class for this. Finally, you modified proxy_attr.h and added your attributes. These should be kept internal to your slurm proxy. Let me know if you have any questions.
Created attachment 151636 [details] New SLURM support patch generated as required This patch is generated after changing some source codes as required using Eclipse->Team->Creat patch... . It includes both the source code patch and binary GIF image files. I'm not sure if the binary image files included in the patch file works, since diff can't handle binary file. If not, I can upload the source code patch and binary image files separately.
Committed. The only change I made was to move the icons to the slurm plugin. Also made some changes to remove dependency on rm.remote plugin which has been deprecated.
