Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 291639 - [Help][Context] Dead code in ContextManager
Summary: [Help][Context] Dead code in ContextManager
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: User Assistance (show other bugs)
Version: 3.5   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.6 M4   Edit
Assignee: Chris Austin CLA
QA Contact: Chris Austin CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-10-07 13:28 EDT by Chris Goldthorpe CLA
Modified: 2009-11-24 17:12 EST (History)
0 users

See Also:

Attachments
Patch to remove obsolete code (2.32 KB, patch)
2009-11-24 15:37 EST, Chris Austin CLA 		cgold: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Goldthorpe CLA 2009-10-07 13:28:28 EDT 
org.eclipse.help.internal.context.ContextManager.addContext(IContext) is never called. It can be deleted as can contextsById, idsByContext, idCounter and the code that looks for dynamic contexts.
Comment 1 Chris Austin CLA 2009-11-24 15:37:07 EST 
Created attachment 153009 [details]
Patch to remove obsolete code

Created a patch which removes the dead code.  No indications that this will break anything.
Comment 2 Chris Goldthorpe CLA 2009-11-24 16:55:35 EST 
Patch committed to HEAD, fixed.