This Bugzilla instance is deprecated, and most Eclipse projects now use GitHub or Eclipse GitLab. Please see the deprecation plan for details.
Bug 291547 - [releng] consider including css and properties files in source jars
Summary: [releng] consider including css and properties files in source jars
Status: RESOLVED WONTFIX
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: 3.2   Edit
Hardware: PC Windows 2000
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: David Green CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-10-06 21:42 EDT by yaumunlam CLA
Modified: 2009-10-16 12:13 EDT (History)
2 users (show)

See Also:

Attachments
patch (646 bytes, patch)
2009-10-07 14:35 EDT, Steffen Pingel CLA 		no flags Details | Diff
mylyn/context/zip (619 bytes, application/octet-stream)
2009-10-07 14:35 EDT, Steffen Pingel CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description yaumunlam CLA 2009-10-06 21:42:17 EDT 
Source jars from download.eclipse.org/tools/mylyn/update/e3.4 are incomplete
for Mylyn 3.2.2 Release,
at least .css and .properties are missing for
org.eclipse.mylyn.wikitext.ui.source_1.1.2.v20090912-0400-e3x.jar
Comment 1 Steffen Pingel CLA 2009-10-06 23:31:42 EDT 
David, can you check what WikiText is missing and make a patch that can be back-ported to 3.2.3?
Comment 2 David Green CLA 2009-10-07 12:09:56 EDT 
Sure!  Can you remind me where in the build we're creating these source plug-ins?
Comment 3 Steffen Pingel CLA 2009-10-07 13:03:11 EDT 
The source plug-ins are created by the SDK features. To fix this bug I think all we need to do is add the missing files to the build.properties for the respective plug-ins.
Comment 4 David Green CLA 2009-10-07 13:34:36 EDT 
Documentation on "PDEBuild/Individual Source Bundles":http://wiki.eclipse.org/PDEBuild/Individual_Source_Bundles

Doesn't appear to contain information on how to modify the source file includes.  Any ideas Chris?
Comment 5 Steffen Pingel CLA 2009-10-07 14:35:28 EDT 
Created attachment 149025 [details]
patch
Comment 6 Steffen Pingel CLA 2009-10-07 14:35:31 EDT 
Created attachment 149026 [details]
mylyn/context/zip
Comment 7 Steffen Pingel CLA 2009-10-07 14:36:06 EDT 
As far as I know it is controlled through each plug-in's build.properties (see patch).
Comment 8 David Green CLA 2009-10-07 14:50:54 EDT 
Steffen, I don't think that your attached patch will fix the issue.  The issue is with respect to resource bundles and other resources in the src folder (*.css, *.properties)
Comment 9 Steffen Pingel CLA 2009-10-07 15:28:42 EDT 
Oh, I see. Then I'll let you figure out how to get those into the build :).
Comment 10 David Green CLA 2009-10-08 13:21:14 EDT 
@yaumunlam can you state your use case?  These files are already included in org.eclipse.mylyn.wikitext.ui.  Why are they needed in the source bundle?
Comment 11 yaumunlam CLA 2009-10-08 21:53:38 EDT 
(In reply to comment #10)
> @yaumunlam can you state your use case?  These files are already included in
> org.eclipse.mylyn.wikitext.ui.  Why are they needed in the source bundle?

I need to change some of the source code of the source bundle by importing it as importing from cvs server is very slow (always timeout).
Comment 12 Steffen Pingel CLA 2009-10-13 18:34:52 EDT 
I'll remove the milestone for now since we have already in the process of preparing the final build for 3.3. We can consider this for 3.2.3 or 3.4 if there is a straight forward solution.
Comment 13 David Green CLA 2009-10-16 12:13:25 EDT 
(In reply to comment #11)
> I need to change some of the source code of the source bundle by importing it
> as importing from cvs server is very slow (always timeout).

The source plug-ins are not intended as a means to distribute the source code for rebuilding WikiText.  For that I recommend obtaining source directly from CVS.  If you're having issues with the CVS server, please file a bug with the specifics of your issue.

As a workaround in your case, you could extract the non-Java resources (eg: plugin.xml, MANIFEST.MF, images, *.css, *.properties, etc.) from the plug-in jars.