Community
Participate
Working Groups
Created attachment 148841 [details] TableCombo Eclipse project. This widget has the following features: o Supports displaying multiple columns of data in the drop down portion of the combo. o Supports displaying a header for the drop down portion of the combo. Supports images for each column that is displayed within the drop down portion of the combo. o Supports custom Colors and Fonts for each Row & Column within the drop down portion of the combo. o Supports displaying a % of the full drop down portion of the combo. So you can specify that the viewable portion of the drop down will be 75% of the full width of the table and a Horizontal scrollbar will be displayed.
Created attachment 148959 [details] Refactored TableCombo This archive has the TableCombo widget refactored so that there is a straight SWT TableCombo widget and a TableComboViewer. The code is getting closer but I am still not happy with a few things.
Created attachment 149136 [details] Updated Widget with new package names and added some new features I added in the EPL header on all the source and updated the package names to be consistent with the nebula package structure. I also added a few new features to the TableCombo. 1. Made it easier to specify the column definitions within the TableCombo. 2. Table Columns by default will now be auto sized based upon the content in them so you don't have to specify a column width unless you want to override the calculated value.
Ok took a look and I file a CQ. Just one comment you should make a Plugin-Project from it using the PDE-Wizard and name the project 'org.eclipse.nebula.widgets.tablecombo'.
Filed CQ: https://dev.eclipse.org/ipzilla/show_bug.cgi?id=3568
Created attachment 149302 [details] Updated Project to be a Plugin Project. Updated widget's project to be a plugin project.
Marty, can you verify that: 1. You authored 100% of the contribution 2. You have the rights to donate the content to Eclipse 3. You are contributing the content under the EPL
Chris, Sure, I have included my responses below. (In reply to comment #6) > Marty, can you verify that: > 1. You authored 100% of the contribution I used the CCombo class a good bit as a reference for my widget. Basically I took the CCombo class and replaced the List control with a Table control and then added additional logic for sizing and convience. I also used the TableViewer class a good bit as a reference when creating my TableComboViewer class. > 2. You have the rights to donate the content to Eclipse I do have the rights to donate this widget because I wrote it in my free time one weekend. > 3. You are contributing the content under the EPL I am contributing the widget under EPL.
Marty, here's some comments from the Eclipse legal team to get addressed. -- Can you please check with the contributor regarding the following: 1. TableComboViewer.java indicates that IBM was a contributor to the file - see: # Contributors: # * IBM Corporation - SWT's TableViewer was used as a guideline to build this class I do not believe IBM's attribution should be contained in the ontribution Section but moved below the header. 2. TableComboViewerRow.java is matching 71% to an original Eclipse file with copyright belonging to IBM. As such, IBM would be the copyright holder of this file with the contributor listed only in the Contributor Section. 3. TableCombo.java also matches quite a bit to an original Eclipse file with copyright belonging to IBM. As such, #2 revisions would apply to this file as well. 4. icon_favorite.gif is matching to a third party gif that does not appear to originate from Eclipse??? 5. icon_accept.gif appears to originate from Fam Fam (Silk). While some icons are approved for use in Eclipse from Silk, this project would need to check if this icon is included in the original package which was approved and then "piggyback" off the approved CQ. Please work with the contributor to gain a new attachment.
Chris, I am working on a few changes to the widget and I will update the epl license header information as they suggested. As far as the icons are concerned, I just grabbed two icons for the code snippets. The icons are not really part of the widget. Are there any stock icons that are part of eclipse that are 16 x 16 that I could use instead? (In reply to comment #8) > Marty, here's some comments from the Eclipse legal team to get addressed. > > -- > > Can you please check with the contributor regarding the following: > > 1. TableComboViewer.java indicates that IBM was a contributor to the file - > see: > # Contributors: > # * IBM Corporation - SWT's TableViewer was used as a guideline to build > this class > > I do not believe IBM's attribution should be contained in the ontribution > Section but moved below the header. > > 2. TableComboViewerRow.java is matching 71% to an original Eclipse file with > copyright belonging to IBM. As such, IBM would be the copyright holder of this > file with the contributor listed only in the Contributor Section. > > 3. TableCombo.java also matches quite a bit to an original Eclipse file with > copyright belonging to IBM. As such, #2 revisions would apply to this file as > well. > > 4. icon_favorite.gif is matching to a third party gif that does not appear to > originate from Eclipse??? > > 5. icon_accept.gif appears to originate from Fam Fam (Silk). While some icons > are approved for use in Eclipse from Silk, this project would need to check if > this icon is included in the original package which was approved and then > "piggyback" off the approved CQ. > > Please work with the contributor to gain a new attachment.
(In reply to comment #9) > Chris, > > I am working on a few changes to the widget and I will update the epl license > header information as they suggested. As far as the icons are concerned, I > just grabbed two icons for the code snippets. The icons are not really part of > the widget. Are there any stock icons that are part of eclipse that are 16 x > 16 that I could use instead? I generally look for icons on http://www.iconlet.com/ Make sure they are EPL or under an EPL-friendly license. Not sure if Tom has ideas about icons.
Nothing but I'd suggest using one from the eclipse projects for snippets [1] and generally speaking I would remove the snippet from the initial contribution source and once you are a committer add the snippets. I simply unzipped some of the eclipse plugins and then you have enough icons to play with. Another thing we did in the past in snippets is to dynamically create icons using SWT-GC. [1]http://xantorohara.110mb.com/core-icons/Eclipse-16x16.html
Tom, Good Idea, I will remove the snippets from the initial contribution until all the acceptance process is complete. (In reply to comment #11) > Nothing but I'd suggest using one from the eclipse projects for snippets [1] > and generally speaking I would remove the snippet from the initial contribution > source and once you are a committer add the snippets. > > I simply unzipped some of the eclipse plugins and then you have enough icons to > play with. Another thing we did in the past in snippets is to dynamically > create icons using SWT-GC. > > [1]http://xantorohara.110mb.com/core-icons/Eclipse-16x16.html
Created attachment 149707 [details] Updated Widget 1. Updated EPL Comments as requested by Eclipse Foundation. 2. Removed Snippets from source for now. 3. Refactored Widget so that it uses a Text field in combination with a Label field instead of using a CLabel field to display the selected text and image.
Just wanted to check in to see if there is anything else I need to do? Generally how long does the approval process take? Just Wondering, Marty (In reply to comment #13) > Created an attachment (id=149707) [details] > Updated Widget > > 1. Updated EPL Comments as requested by Eclipse Foundation. > 2. Removed Snippets from source for now. > 3. Refactored Widget so that it uses a Text field in combination with a Label > field instead of using a CLabel field to display the selected text and image.
(In reply to comment #14) > Just wanted to check in to see if there is anything else I need to do? > Generally how long does the approval process take? It varies depending how busy the Eclipse legal team is. I just attached your new source for the tablecombo the Eclipse IPZilla: https://dev.eclipse.org/ipzilla/show_bug.cgi?id=3568 Once you're a committer, you'll be able to access that. Tom, are you going to nominate Marty to own this widget at Nebula :)? I think your paperwork is good according to the IP team.
Created attachment 150436 [details] Fixed issue with TableComboViewer Fixed bug with initial value not being displayed in the selected portion of the TableCombo.
(In reply to comment #15) > (In reply to comment #14) > > Just wanted to check in to see if there is anything else I need to do? > > Generally how long does the approval process take? > > It varies depending how busy the Eclipse legal team is. > > I just attached your new source for the tablecombo the Eclipse IPZilla: > https://dev.eclipse.org/ipzilla/show_bug.cgi?id=3568 > > Once you're a committer, you'll be able to access that. > > Tom, are you going to nominate Marty to own this widget at Nebula :)? > > I think your paperwork is good according to the IP team. The voting is open.
(In reply to comment #16) > Created an attachment (id=150436) [details] > Fixed issue with TableComboViewer > > Fixed bug with initial value not being displayed in the selected portion of the > TableCombo. Is this a patch or a zip? It's marked as a patch.
Matthew, It is a zip. I marked it incorrectly. The attachment is the latest and greatest of the TableCombo and TableComboViewer. I can email you some snippets for the controls if you like. I removed the snippets from the zip file while the source is going through the approval process. Marty (In reply to comment #18) > (In reply to comment #16) > > Created an attachment (id=150436) [details] [details] > > Fixed issue with TableComboViewer > > > > Fixed bug with initial value not being displayed in the selected portion of the > > TableCombo. > > Is this a patch or a zip? It's marked as a patch.
I'm interested in using this widget when it is ready. I'm curious if it supports tooltips over the main combo area, as well as for each item when the list is displayed? Thanks
(In reply to comment #20) > I'm interested in using this widget when it is ready. > > I'm curious if it supports tooltips over the main combo area, as well as for > each item when the list is displayed? > > Thanks Adam, The TableCombo widget has been approved and we are finishing up paperwork now so hopefully it will be available soon. Tooltips for the main combo area are currently supported. I will take a look to see if I can add ToolTip support at the table cell level. I found a few examples of making a "fake" tool tip in a regular Table and I believe that Tooltip support was added to the TableViewerColumn for TableViewers in Eclipse 3.5 or 3.6. I Marty
I've got a NoClassDefFoundError for SWTEventListener and changed the import style from packages to the org.eclipse.ui plugin. Now everything works fine. Tanks a lot.
I have seen that the width of images is not correctly handled if it is wider than 16 px. the layout of the drop-down table is ok, but the layout in the text box shows the image on top of the text, hiding the first characters of the text sometimes.
(In reply to comment #23) > I have seen that the width of images is not correctly handled if it is wider > than 16 px. the layout of the drop-down table is ok, but the layout in the text > box shows the image on top of the text, hiding the first characters of the text > sometimes. Enrico, What size image are you using? I will let you know when Bugzilla has the TableCombo widget as a valid option to report a bug and you can create a new Bug against the widget. Thanks, Marty
(In reply to comment #23) > I have seen that the width of images is not correctly handled if it is wider > than 16 px. the layout of the drop-down table is ok, but the layout in the text > box shows the image on top of the text, hiding the first characters of the text > sometimes. Enrico, The TableCombo has now been added to BugZilla so you can now enter a new bug describing the issue you are seeing with the images. Thanks, Marty
the component name ends with a ^ sign... this might be the reason why i can't see it within mylyn...
(In reply to comment #26) > the component name ends with a ^ sign... this might be the reason why i can't > see it within mylyn... That is a type-oh. We are working to get that corrected. Marty
(In reply to comment #26) > the component name ends with a ^ sign... this might be the reason why i can't > see it within mylyn... typo from me :-( ... but might I also suggest to log a bug against mylyn because they should not fail right?
Marty I guess you can now close this bug because the sources are in the repo.
Closed since the source code is now in the repository.
(In reply to comment #28) > typo from me :-( ... but might I also suggest to log a bug against mylyn > because they should not fail right? done so... Bug #294976
