Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 291303 - Selection of Git repository location is broken
Summary: Selection of Git repository location is broken
Status: RESOLVED FIXED
Alias: None
Product: EGit
Classification: Technology
Component: UI (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 blocker (vote)
Target Milestone: ---   Edit
Assignee: Shawn Pearce CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 292592
  Show dependency tree
 
Reported: 2009-10-04 19:37 EDT by Mykola Nikishov CLA
Modified: 2014-03-27 16:46 EDT (History)
4 users (show)

See Also:

Attachments
proposed implementation (7.10 KB, patch)
2009-10-04 19:40 EDT, Mykola Nikishov CLA 		sop: iplog+
sop: review+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mykola Nikishov CLA 2009-10-04 19:37:59 EDT 
Selection of of Git repository location in Configure Git repository dialog is broken.

Steps to reproduce:
- Create git repository in a directory '/a/'
- Create new project in '/a/b/c/nested-dir'
- Share project using context menu, select Git, Next, select project
- The create button is disabled, repository field contains '../../.git'

What was expected:
- it should be possible to create a new repository in the project's root under  '/a/b/c/nested-dir/.git'
- it should be possible to share project using repository under '/a/.git'
Comment 1 Mykola Nikishov CLA 2009-10-04 19:40:01 EDT 
Created attachment 148729 [details]
proposed implementation
Comment 2 Shawn Pearce CLA 2009-10-16 12:59:10 EDT 
Committed as dcd861db6f364c9c41a2409fd90ad2f91bcd7f54
Comment 3 Mykola Nikishov CLA 2009-10-17 18:21:32 EDT 
It's still impossible to share a project which is located in a directory nested into other git repository. In other words it will fail for this use case:
- you have a git repository under '/home/abc/.git';
- you have a nested git repository under '/home/abc/src/cool-project/.git' (no matter if it was already existed or just created in the wizard using 'Create...' button);
- and you are trying to configure a git repository for a project located in '/home/abc/src/cool-project/'.

Wizard will close after clicking a 'Finish' button without performing any actions. At least, there will be no any damage ;-)

Sorry for inconvenience, I'll fix this ASAP.
Comment 4 Mykola Nikishov CLA 2009-10-18 09:58:43 EDT 
Fix available for review, http://egit.eclipse.org/r/84
Comment 5 Mykola Nikishov CLA 2009-11-30 11:07:35 EST 
This should be fixed ASAP (actually, the patch from http://egit.eclipse.org/r/84 should be applied):

* Robin Rosenberg has caught this, bug 296463
* Igor Fedorenko "blocked":http://dev.eclipse.org/mhonarc/lists/egit-dev/msg00362.html  on providing Tycho Build for EGit
Comment 6 Shawn Pearce CLA 2009-11-30 20:39:20 EST 
Change Id6f30efd6a4d10a4f1946e92dc54e51972166be9 (/r/84) applied.
Comment 7 Wayne Beaton CLA 2014-03-27 16:46:18 EDT 
Removing the iplog flag. There's no IP in any of the comments.