Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 291103 - Assertions failing in Make Private Entity Public refactoring
Summary: Assertions failing in Make Private Entity Public refactoring
Status: RESOLVED FIXED
Alias: None
Product: PTP
Classification: Tools
Component: Photran.Refactoring Engine (show other bugs)
Version: 4.0   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Kurt Hendle CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-10-01 16:11 EDT by Jeffrey Overbey CLA
Modified: 2011-05-14 06:41 EDT (History)
0 users

See Also:

Attachments
Update to Make Private Public - tests passing (30.05 KB, patch)
2009-10-02 10:26 EDT, Kurt Hendle CLA 		g.watson: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jeffrey Overbey CLA 2009-10-01 16:11:17 EDT 
Kurt -- I just realized I forgot that, in the launch configuration for the JUnit test suite, we're supposed to have assertions enabled (click on the Arguments tab in the run configuration, and put "-ea" in the VM arguments).  (There was an incorrect assertion in Rename that was failing that I just fixed.)

When these are enabled, "assert accessNode != null" on line 248 of MakePrivateEntityPublicRefactoring is failing for tests 4, 6, and 7_1.
Comment 1 Kurt Hendle CLA 2009-10-02 10:26:44 EDT 
Created attachment 148649 [details]
Update to Make Private Public - tests passing

I believe those 2 assertions at lines 248 and 249 are actually not necessary the necessary checks happen in the methods themselves to determine the change being made.

I've removed those and added an update attachment that patches only the refactoring code file, namely MakePrivateEntityPublicRefactoring.java.
Comment 2 Jeffrey Overbey CLA 2009-10-02 10:50:02 EDT 
Sounds good.  You can go ahead and commit that patch.  Actually, you don't even have to post patches now that you're a committer.  :-)  Just mention that it's fixed in CVS.

Jeff
Comment 3 Jeffrey Overbey CLA 2009-10-08 12:43:45 EDT 
Committed to CVS