Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 290676 - T0001_ConnectProviderOperationTest fails
Summary: T0001_ConnectProviderOperationTest fails
Status: RESOLVED FIXED
Alias: None
Product: EGit
Classification: Technology
Component: Core (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Matthias Sohn CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-09-28 05:32 EDT by Stefan Lay CLA
Modified: 2014-03-27 16:47 EDT (History)
3 users (show)

See Also:
matthias.sohn: review+


Attachments
http://egit.eclipse.org/r/93 (1.42 KB, patch)
2009-11-08 12:14 EST, Mykola Nikishov CLA
matthias.sohn: iplog+
matthias.sohn: review+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Stefan Lay CLA 2009-09-28 05:32:25 EDT
The test case T0001_ConnectProviderOperationTest fails with an AssertionFailedError:

testNoRepository(org.eclipse.egit.core.op.T0001_ConnectProviderOperationTest)
junit.framework.AssertionFailedError
	at junit.framework.Assert.fail(Assert.java:47)
	at junit.framework.Assert.assertTrue(Assert.java:20)
	at junit.framework.Assert.assertTrue(Assert.java:27)
	at org.eclipse.egit.core.op.T0001_ConnectProviderOperationTest.testNoRepository(T0001_ConnectProviderOperationTest.java:44)

In the test method testNoRepository the ConnectProviderOperation is run, but no Repository exists. The project is therefore not shared.

However, there is a check

assertTrue(RepositoryProvider.isShared(project.getProject()));

Is this an error in the testcase or in the tested coding?
Comment 2 Mykola Nikishov CLA 2009-11-08 12:14:20 EST
Created attachment 151645 [details]
http://egit.eclipse.org/r/93
Comment 3 Matthias Sohn CLA 2009-11-12 05:52:31 EST
committed as 75df95f31fe3d67df9bfc82b5c3b6b789a89a205
Comment 4 Wayne Beaton CLA 2014-03-27 16:47:01 EDT
Removing the iplog flag. There's no IP in any of the comments.