Community
Participate
Working Groups
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US) AppleWebKit/532.0 (KHTML, like Gecko) Chrome/3.0.195.21 Safari/532.0 Build Identifier: wtp 3.0.5 Backport the fix for bugzilla#282936 to wtp 3.0.5 Reproducible: Always Steps to Reproduce: Since the fix for bugzilla#282936 greatly improved the performance of loading metadata, we expect the fix can also be in wtp 3.0.5 so that the products adopting wtp 3.0 can also benefit.
Created attachment 148131 [details] fix Based on the patch in bugzilla#282936.
Is the fix to the test required? Or just happened to be included here? I ask since we do not normally fix tests in patch streams. So, perhaps you could at least split up the patch into the code portion, and the test portion (if the test portion is important here). thanks,
Comment on attachment 148131 [details] fix changing to "patch" attachment
(In reply to comment #2) > Is the fix to the test required? Or just happened to be included here? > > I ask since we do not normally fix tests in patch streams. > > So, perhaps you could at least split up the patch into the code portion, and > the test portion (if the test portion is important here). > > thanks, No, it is not required. It is there because the original patch in bugzilla#282936 has this change.
Created attachment 148159 [details] fix forgot to select the "patch" checkbox.
(In reply to comment #4) > (In reply to comment #2) > > No, it is not required. It is there because the original patch in > bugzilla#282936 has this change. Ok, thanks. Please re-attach new patch without the test bundle change. I just want to be sure it is very clear what needs to be done ... both for now, and 6 months in the future :)
Created attachment 148166 [details] fix removed the test.
Requesting high priority for 3.0.5 patch, for some IBM adopters. I'll provide more exact instructions shortly.
We've used a "test patch" to confirm this fix works as expected. General procedure for creating patch feature. To create patches, our latest general documentation is at http://wiki.eclipse.org/WTP/Build/WTP_Patches_for_Release_2.0.2 and may be "dated" in some of the specifics, but the concepts are the same. But here's the specifics for these 4 JSF bugs requested for 3.0.5 patches: The patches involve 2 bundles, and the starting point is of course what was released in WTP 3.0.5, which can be found by looking in the map files for that release. First, load these bundles with these tag names into workspace: org.eclipse.jst.jsf.common v20090128 org.eclipse.jst.jsf.core v20090508 From those, use "Team, Branch ..." to create a branch named R3_0_5_patches Apply the patches, and commit (to that branch) with appropriate cvs comments to reflect the bugs fixed. Once all have been committed, then use "Team, Tag as Version ..." to tag those revisions with something like the usual tag name, such as v200909281200 Then let us know what tagged you used (for each bundle, if not exactly the same). Carl or I will do the rest. The feature these bundles were in was org.eclipse.jst.web_core.feature so they will go into a patch feature named org.eclipse.jst.web_core.feature.patch, which already exists in the R3_0_5_patches stream. Similarly, Carl or I can "manually" update the map files in releng.jsf which have already been branched to R3_0_5_patches. And, finally, we will do the actual build and make it available in the usual place: http://download.eclipse.org/webtools/patches/ Be sure to merge or re-apply the fixes to 3.1.2 and Helios steams.
Backport the fix for bug 282936
Created attachment 148677 [details] patch for tests I have diffed and verified that the attached fix patch contains all the fixes in the Galileo original. The only differences being with some $NON-NLS-N$ comments, and the removal of patch to the tests. I have also run all of the JUnits and performed some manual testing to ensure that this patch is good. I have added back the patch for the tests in a separate file since it is necessary to allow the JUnits to succeed, and was not an enhancement. All is good. Raghu, please apply both patches to the 3.0.5 branch.
Tagged as v200910042227
fixed
