Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 290147 - [Help] Remote Help and unescaped characters in path
Summary: [Help] Remote Help and unescaped characters in path
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: User Assistance (show other bugs)
Version: 3.5   Edit
Hardware: PC Windows Vista
: P3 normal (vote)
Target Milestone: 3.6 M3   Edit
Assignee: Chris Austin CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-09-22 11:28 EDT by Enrico Schenk CLA
Modified: 2009-10-06 14:01 EDT (History)
2 users (show)

See Also:


Attachments
Patch V1 (1.13 KB, patch)
2009-09-28 14:47 EDT, Chris Austin CLA
cgold: iplog+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Enrico Schenk CLA 2009-09-22 11:28:16 EDT
I've setup an Infocenter using Tomcat. This works as expected and the help pages are accessible within the browser. The problem is that the Infocenter cannot be used remotely. Although the content of generated TOC's can be retrieved, the loading of the help pages itself fails. It turned out that paths of the help pages contained spaces, once those characters were removed everything worked fine. My assumption is that the special characters are not escaped when requesting the remote documents.
Comment 1 Chris Austin CLA 2009-09-28 14:47:49 EDT
Created attachment 148266 [details]
Patch V1

Yes, I was able to reproduce this issue with a space in the folder name to a remote help document.

I have added a call to URIUtil.fromString(url).toString(); to properly escape the URL special characters, and this seems to resolve the issue.

I have tested this with a remote document, a local document, and a document which contains no spaces; all 3 cases work as expected. Chris G - any other test cases here?
Comment 2 Chris Goldthorpe CLA 2009-09-28 17:47:25 EDT
You might want to test folders containing any of '&', '<' or '>' since these are special characters which ofter cause encoding problems. It's too bad we don't have any automated tests for remote help. I think it would be possible to automate a lot of the data retrieval and Toc merging - I should probably open a bug for that.
Comment 3 Chris Austin CLA 2009-10-05 13:00:19 EDT
Well, I tried it with '&' and that seems to work.  Eclipse won't let you create folders with '<' or '>' in it, so I didn't test those two.
Comment 4 Chris Goldthorpe CLA 2009-10-06 14:01:18 EDT
Patch committed, Fixed.