Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 289725 - SOAP arguments Regular Expression is incorrect
Summary: SOAP arguments Regular Expression is incorrect
Status: VERIFIED FIXED
Alias: None
Product: Data Tools
Classification: Tools
Component: Enablement:ODA (show other bugs)
Version: Ganymede   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 1.9   Edit
Assignee: xiaofeng zhang CLA
QA Contact: Xiaoying Gu CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-09-17 08:38 EDT by Andre Ribeiro CLA
Modified: 2011-05-31 18:44 EDT (History)
4 users (show)

See Also:
bpayton: iplog+

Attachments
SOAP example (8.57 KB, application/xml)
2009-09-17 08:40 EDT, Andre Ribeiro CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andre Ribeiro CLA 2009-09-17 08:38:48 EDT 
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.3) Gecko/20090824 Firefox/3.5.3 (.NET CLR 3.5.30729)
Build Identifier: 20090621-0832

The regular expression in variable 
org.eclipse.datatools.enablement.oda.ws.soap.SOAPRequest.RE_PARAMETER
should be replaced by (&\\?)(\\w+)(\\?&) or otherwise it wont find SOAP Parameters inside XML attributes.

Reproducible: Always

Steps to Reproduce:
1. Create a new org.eclipse.datatools.enablement.oda.ws.soap.SOAPRequest object
using a template with arguments in XML attributes (an example/use case of this situation would be a SOAP Request with a <gml:point> in a SOAP Request as in the excerpt one attached.

2. Confirm that, on line 48 of org.eclipse.datatools.enablement.oda.ws.soap.SOAPRequest (version 1.5)
template = queryText.split( RE_PARAMETER );
the split is incorrect on:
gml:id="&?point1_Id?&" gid="&?point1_gId?&"
Comment 1 Andre Ribeiro CLA 2009-09-17 08:40:48 EDT 
Created attachment 147433 [details]
SOAP example
Comment 2 Linda Chan CLA 2010-09-01 22:56:23 EDT 
It didn't make it in the 1.8.1 release; moved to the next maintenance release.
Comment 3 xiaofeng zhang CLA 2011-04-15 03:34:44 EDT 
The regular expression "\\Q&?\\E.*\\Q?&\\E" is incorrect on this case, there is more than one parameter in one line. Fix this bug.
Comment 4 Xiaoying Gu CLA 2011-04-15 04:04:14 EDT 
Verified in os birt 3.7.0.v20110415-0630