Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 289409 - [Viewers] ILazyTreePathContentProvider documentation request
Summary: [Viewers] ILazyTreePathContentProvider documentation request
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.6   Edit
Hardware: PC Windows Vista
: P3 normal (vote)
Target Milestone: 3.6 M4   Edit
Assignee: Boris Bokowski CLA
QA Contact: Boris Bokowski CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-09-14 22:20 EDT by John Cortell CLA
Modified: 2009-12-08 10:09 EST (History)
1 user (show)

See Also:

Attachments
Proposed javadoc enhancement (3.11 KB, patch)
2009-10-13 18:06 EDT, John Cortell CLA 		bokowski: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description John Cortell CLA 2009-09-14 22:20:10 EDT 
I believe the JavaDoc for ILazyTreePathContentProvider#updateElement() should mention that the implementation can call TreeViewer#setHasChildren() instead of TreeViewer#setChildCount() if the content provider can more efficiently determine the has-children status than it can the actual number of children. This optimization was made possible by 156883. I think it needs to be advertised so clients can take advantage of it in their implementation of ILazyTreePathContentProvider#updateElement().

In fact, I think clients that use ILazyTreeContentProvider also have access to that optimization. If so, that JavaDoc should be updated, too.
Comment 1 Boris Bokowski CLA 2009-10-13 17:22:15 EDT 
Thank you for filing this bug. Would you be able to contribute a patch, too?

http://wiki.eclipse.org/Platform_UI/How_to_Contribute
Comment 2 John Cortell CLA 2009-10-13 18:06:03 EDT 
Created attachment 149484 [details]
Proposed javadoc enhancement

Certainly. Here you go.
Comment 3 Boris Bokowski CLA 2009-11-11 11:56:53 EST 
Released to HEAD. Thanks for the patch!
Comment 4 Remy Suen CLA 2009-12-08 10:09:00 EST 
Verified on I20091208-0100 via source code inspection. Thanks for the bug report and the patch, John!
Comment 5 Remy Suen CLA 2009-12-08 10:09:13 EST 
Whoops, forgot to mark as verified.