Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 289239 - [Progress] Show a generic icon when Job has no image
Summary: [Progress] Show a generic icon when Job has no image
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.6   Edit
Hardware: PC Windows XP
: P3 enhancement (vote)
Target Milestone: 3.6 M3   Edit
Assignee: Prakash Rangaraj CLA
QA Contact: Prakash Rangaraj CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-09-11 13:16 EDT by Markus Keller CLA
Modified: 2009-10-27 12:58 EDT (History)
1 user (show)

See Also:

Attachments
using the progress_task.gif (20.98 KB, image/png)
2009-10-09 00:51 EDT, Prakash Rangaraj CLA 		no flags Details
using the progress_task.gif (45.69 KB, image/png)
2009-10-09 01:05 EDT, Prakash Rangaraj CLA 		no flags Details
Patch v01 (1.11 KB, patch)
2009-10-09 01:11 EDT, Prakash Rangaraj CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Keller CLA 2009-09-11 13:16:50 EDT 
(In reply to bug 229294 comment #8)
> (In reply to bug 229294 comment #0)
> > 2) I think it would look better if items without images would have their label
> > text vertically aligned with the text of items with images. 
> [..]
>  2) That would look nice if all the jobs have 16x16 icons. But there is no
> constraint on the image size and the user is allowed to have any sized icon. In
> this case, it would not look nice, if all the progress bars are aligned to the
> biggest icon in the view

It would look better if you could just give jobs without an icon a generic image.
Comment 1 Susan McCourt CLA 2009-10-08 13:15:21 EDT 
I think that org.eclipse.ui.icons.full.progress.progress_task.gif was designed for this purpose (to show a generic task in the progress view.)  Note that it is used as part of the Progress view icon.  However, it is smaller (12x12) than the 20x20 icons that are used to show state, so text alignment would still be an issue.  (Is text alignment still an issue or are you just looking for a nice graphic?)  

I think we should try progress-task.gif and see how it looks in context.
Comment 2 Prakash Rangaraj CLA 2009-10-09 00:51:19 EDT 
Created attachment 149202 [details]
using the progress_task.gif

(In reply to comment #1)
> I think that org.eclipse.ui.icons.full.progress.progress_task.gif was designed
> for this purpose (to show a generic task in the progress view.)  Note that it
> is used as part of the Progress view icon.  However, it is smaller (12x12) than
> the 20x20 icons that are used to show state, so text alignment would still be
> an issue.  (Is text alignment still an issue or are you just looking for a nice
> graphic?)  

     Alignment is not an issue.

> I think we should try progress-task.gif and see how it looks in context.

     It looks OK to me.
Comment 3 Prakash Rangaraj CLA 2009-10-09 01:05:26 EDT 
Created attachment 149203 [details]
using the progress_task.gif

In the Dialog
Comment 4 Prakash Rangaraj CLA 2009-10-09 01:11:49 EDT 
Created attachment 149204 [details]
Patch v01
Comment 5 Prakash Rangaraj CLA 2009-10-12 03:33:47 EDT 
Patch v01 released to HEAD.
Comment 6 Prakash Rangaraj CLA 2009-10-27 12:58:18 EDT 
Verified in I20091027-0100.