Bug 289164 – Toast contribution

Bug 289164 - Toast contribution


Summary:	Toast contribution

Status:	RESOLVED FIXED

Product:	z_Archived
Classification:	Eclipse Foundation
Component:	Examples
Version:	unspecified
Hardware:	PC Mac OS X - Carbon (unsup.)

Importance:	P3 normal (vote)
Target Milestone:	---
Assigned To:	Project Inbox
QA Contact:

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:
	Show dependency tree

Reported:	2009-09-10 21:21 EDT by Jeff McAffer
Modified:	2014-01-10 10:49 EST (History)
CC List:	4 users (show)

See Also:

Attachments
Main body of toast code (EPL/EDL) (6.41 MB, application/x-zip-compressed) 2009-09-10 21:24 EDT, Jeff McAffer	no flags	Details
Part of Toast that includes Apache licensed code (74.68 KB, application/x-zip-compressed) 2009-09-10 21:25 EDT, Jeff McAffer	no flags	Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Jeff McAffer

2009-09-10 21:21:59 EDT

As previously discussed, we would like to contribute the Toast example code to the Examples project.  For your CQ pleasure I have provided below the relevant info for the portal wizard.

Name : Toast

Description : Toast is a example application demonstrating a wide range of EclipseRT technology.

Reason: New feature

Crypto: oia7rn0j2XRT)w  (errr, no, not at all cryptic)

Authors:
Jeff McAffer : 31.6667% (existing Eclipse committer)
Simon Archer : 31.6667% (existing Eclipse committer)
Paul VanderLei : 31.6667% BandXI pv@bandxi.com
Holger Staudacher : 1% EclipseSource hstaudacher@eclipsesource.com
Benjamin Muskalla : 1% (existing Eclipse committer)
Ralf Sternberg : 1% (existing Eclipse committer)
Ed Merks : 1% (there is only one)
Ian Bull : 1% (existing Eclipse committer)

There are / will be two attachements, one for the main body of code that is EPL /EDL and one for a body of code that has some Apache 2.0 stuff in it.  I was advised by the IP team that separate CQs would be needed for these.

Comment 1 Jeff McAffer

2009-09-10 21:24:51 EDT

Created attachment 146921 [details]
Main body of toast code (EPL/EDL)

Comment 2 Jeff McAffer

2009-09-10 21:25:43 EDT

Created attachment 146922 [details]
Part of Toast that includes Apache licensed code

Comment 3 Jeff McAffer

2009-09-10 21:28:32 EDT

NOte that for the second CQ (Apache stuff) the authors were

Jeff
Holger
Benny
Ralf

in equal parts.

Comment 4 Wayne Beaton

2009-09-10 23:00:03 EDT

Hi Jeff. Thanks for the contribution. I have a couple of questions before I create the CQ.

Can you tell me where the sanfran.txt file comes from?

The toast.zip file contains servletbridge.jar. The IP team isn't going to like that. I believe that it's just code reuse from the Equinox project, so we don't need a separate CQ for it. Is this something that you can remove?

Comment 5 Jeff McAffer

2009-09-10 23:34:24 EDT

> Can you tell me where the sanfran.txt file comes from?

That file was generated using one of the public geo tagging services out there.  Basically you give a lat and lon and it tells you an address at that location. Right now I don't recall the service used.

> The toast.zip file contains servletbridge.jar. The IP team isn't going to like
> that. I believe that it's just code reuse from the Equinox project, so we don't
> need a separate CQ for it. Is this something that you can remove?

Servletbridge.jar is indeed the one from the  Equinox project.  It can be removed from the submission

Comment 6 Benjamin Muskalla

2009-09-11 03:52:56 EDT

Just for the sake of completeness, Holger Staudacher is already an Eclipse Committer on the RAP project (http://dash.eclipse.org/dash/commits/web-app/summary.cgi?type=y&year=x&top=rt&project=rt.rap&company=Innoopract&login=hstaudacher)

Comment 7 Wayne Beaton

2009-09-15 21:30:57 EDT

I've opened CQ 3536 for this contribution.

https://dev.eclipse.org/ipzilla/show_bug.cgi?id=3536

Comment 8 Ray Kelm

2009-10-14 09:25:47 EDT

I just checked out the Toast project code using the instructions in the wiki (http://wiki.eclipse.org/Toast), and the project has compile errors. It looks like there are two bundles that didn't make it into CVS:

org.eclipse.examples.toast.rap.widgets.drivingsimulator
org.eclipse.examples.toast.dev.google

Since there is at least one blog posting that refers to the wiki page now (http://eclipsesource.com/blogs/2009/10/13/toasteclipse/) I'm sure others are going to notice too.

Comment 9 Jeff McAffer

2009-10-16 11:12:22 EDT

Thanks Ray.  Yes, these two bundles are the subject of another CQ in the Eclipse IP process.  It has not cleared yet so the code is not committed.  The code will go in as soon as its cleared.

Comment 10 Jeff McAffer

2009-10-16 11:44:14 EDT

Actually, based on your prompting (thanks) I pinged the every helpful IP team and they agreed that we could commit the bulk of the code but without the bit that actually interfaces to google.  This will allow the code to compile and run but the google interop will not work out of the box.  I'll try to provide instructions for how to make it work in the client at least.  

The code has been committed and the .psf updated.

Comment 11 Jeff McAffer

2010-11-12 12:12:33 EST

This was done long ago...  Closing