Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 289019 - unique constraint DDL is added to SQL files even if supportsUniqueKeyConstraints is false
Summary: unique constraint DDL is added to SQL files even if supportsUniqueKeyConstrai...
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Eclipselink (show other bugs)
Version: unspecified   Edit
Hardware: PC All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Nobody - feel free to take it CLA
QA Contact:
URL:
Whiteboard: submitted_patch
Keywords:
Depends on:
Blocks:
 
Reported: 2009-09-09 20:45 EDT by Dies Koper CLA
Modified: 2022-06-09 10:24 EDT (History)
1 user (show)

See Also:

Attachments
add supportsUniqueKeyConstraints() check before writing ALTER TABLE DROP CONSTRAINTs to SQL file (3.57 KB, patch)
2009-09-09 20:45 EDT, Dies Koper CLA 		peter.krogh: iplog+
Details | Diff
Patch for bugs 289019-289023 (55.24 KB, text/plain)
2009-09-11 16:24 EDT, Tom Ware CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dies Koper CLA 2009-09-09 20:45:37 EDT 
Created attachment 146824 [details]
add supportsUniqueKeyConstraints() check before writing ALTER TABLE DROP CONSTRAINTs to SQL file

Even with supportsUniqueKeyConstraints to false I see ALTER TABLE DROP
CONSTRAINT's in generated DDL files.

The path SchemaManager#dropConstraints
-　TableDefinition#dropConstraintsOnDatabase ...
TableDefinition#dropForeignConstraintsOnDatabase checks for
supportsForeignKeyConstraints before dropping the constraints, while the path
SchemaManager#dropConstraints - TableDefinition#dropConstraintsOnDatabase ...
TableDefinition#dropConstraints does not.
Comment 1 Tom Ware CLA 2009-09-11 16:24:38 EDT 
Created attachment 146999 [details]
Patch for bugs 289019-289023
Comment 2 Tom Ware CLA 2009-09-11 16:30:16 EDT 
Checked in fix for bug 289019, bug 289020, bug 289021 and bug 289023

These fixes are changes suggested by the bug filer and are reasonably simple.

I have reviewed the changes as they were added and run the existing tests to ensure they do not break anything.
Comment 3 Eclipse Webmaster CLA 2022-06-09 10:24:22 EDT 
The Eclipselink project has moved to Github: https://github.com/eclipse-ee4j/eclipselink