Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 288539 - Apply Patch should ignore expanded SVN keywords.
Summary: Apply Patch should ignore expanded SVN keywords.
Status: CLOSED WONTFIX
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Compare (show other bugs)
Version: 3.6   Edit
Hardware: PC Windows XP
: P3 normal with 1 vote (vote)
Target Milestone: ---   Edit
Assignee: Platform-Compare-Inbox CLA
QA Contact:
URL:
Whiteboard: stalebug
Keywords:
Depends on:
Blocks:
 
Reported: 2009-09-03 14:49 EDT by Gary Gregory CLA
Modified: 2021-12-22 17:22 EST (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Gary Gregory CLA 2009-09-03 14:49:10 EDT
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.2) Gecko/20090729 Firefox/3.5.2 (.NET CLR 3.5.30729)
Build Identifier: 

When one creates a diff patch -- in Subclipse or any other tool -- where a
change is "near" an expanded SVN keyword like Id, the local SVN base file does
not contain the expanded keyword by design, so the diff file contains, for example a line with "$Id$" as an unchanged line between the two revisions.

When it is time to apply the patch, the UI reports errors with the white cross
on a red background icon and the patch cannot be 100% applied. Since the patch
contains "$Id$ as an unchanged line and the local copy of the file contains the
keyword expanded, the patch file and local file do not match.

I use TortoiseSVN to apply patches as a workaround, which knows how to handle
this situation.

See http://www.mail-archive.com/tuscany-dev@ws.apache.org/msg30853.html for
another explanation with a SVN diff doc reference.

Reproducible: Always

Steps to Reproduce:
1. Create a file that contains a SVN key work like Id, for example: "@version $Id$ "
2. Enable SVN keywords for Id on this file.
3. Commit to SVN
4. The local file has Id expanded as expected.
5. Now make changes near the line with Id
6. Create a diff patch file.
7. Replace the contents of the file with the SVN version which will loose your changes.
8. Apply the patch you just made.
9. You will see an error because the patch file contains "$Id$" and your local copy has the keyword expanded.
Comment 1 Gary Gregory CLA 2009-09-03 14:50:29 EDT
See informative comment from Subclipse: http://subclipse.tigris.org/issues/show_bug.cgi?id=990
Comment 2 Eclipse Webmaster CLA 2019-09-06 15:36:07 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.
Comment 3 Eclipse Genie CLA 2021-12-22 17:22:06 EST
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. As such, we're closing this bug.

If you have further information on the current state of the bug, please add it and reopen this bug. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.