Community
Participate
Working Groups
Created attachment 146419 [details] New MoDisco common features You can find in the attached patch and in the attached archive a set of common features for MoDisco. These features are necessary to develop the next features. The provided features are: - a MoDisco project nature, that will be used to store all the MoDisco specific files into a dedicated type of project; - a wizard to create new MoDisco projects ; - a MoDisco project builder, that will be used to notify the file events happening into the MoDisco project to the different MoDisco components ; - a MoDisco EMF protocol, that will be used to allow MoDisco EMF models to easily and robustly refer each others. The contributors of these features are: Fabien Giquel and Grégoire Dupé All this contribution is made available under EPL by its different authors whose Employer Consent Forms should have been received by the Foundation. Regards, Grégoire Dupé
Created attachment 146420 [details] org.eclipse.gmt.modisco.infra.common.ui plug-in project archive
Hi guys, Thanks for this important improvement of the MoDisco infrastructure. I will do my best to check your contribution and integrate it as soon as possible. Regards, Hugo
Hi, I successfully integrated your patch and I'm now looking at the new plug-in you contributed in this bug. I don't think the current name of this plug-in is the more relevant one. Should it rather be "org.eclipse.gmt.modisco.common.ui" as indicated by the name of the packages it contains (and as it only depends from the "org.eclipse.gmt.modisco.common.core" plug-in)? Best regards, Hugo
Hi, The mistake is in the package names. The right name is: "org.eclipse.gmt.modisco.infra.common.ui". The package "org.eclipse.gmt.modisco.common.core" should be a soon as possible renamed as "org.eclipse.gmt.modisco.infra.common.core". The added of the "infra" prefix will help to precise that those components are a part of the MoDisco infrastructure. Regards, Grégoire
I saw your point of view. But I think this is a decision that will require some internal discussions as there are several plug-ins which are concerned: - org.eclipse.gmt.modisco.common.core - org.eclipse.gmt.modisco.infra.common.ui (not committed yet) - org.eclipse.gmt.modisco.common.editor - org.eclipse.gmt.modisco.common.editor.extension.xxx - org.eclipse.gmt.modisco.common.editor.extension.yyy - org.eclipse.gmt.modisco.infrastructure.features (the feature gathering the "infrastructure" plug-ins) Instead of the current state, I would rather see something like this: - org.eclipse.gmt.modisco.infrastructure.common.core - org.eclipse.gmt.modisco.infrastructure.common.ui - org.eclipse.gmt.modisco.infrastructure.common.editor - org.eclipse.gmt.modisco.infrastructure.common.editor.extension.xxx - org.eclipse.gmt.modisco.infrastructure.common.editor.extension.yyy - org.eclipse.gmt.modisco.infrastructure.feature As a consequence, we will let this bug in an temporary "awaiting decision" state until we internally agree on a solution. Best regards, Hugo
Hi Gregoire, I have tested the current version of the "common.ui" plug-in. When I create a new MoDisco project using the provided project nature and wizard, there is an error within the MANIFEST.MF of this automatically created project: there is a dependency to the "org.eclipse.gmt.modisco.infra.query.manager" plug-in which is not available from the MoDisco SVN. Please, could you either delete this dependency or contribute this other plug-in as well? Best regards, Hugo
Created attachment 146734 [details] New MoDisco common ui features Hello, You can find in the attached archive (org.eclipse.gmt.modisco.infra.common.ui-20090909-1138.zip) a new version of the "org.eclipse.gmt.modisco.infra.common.ui" plug-in. In this new version, I have: - suppressed the dependency to "org.eclipse.gmt.modisco.infra.query.manager"; - added the "build.properites" file generation (to remove warning on the generated project); - added the ".qualifier" suffix in the "infra.common.ui" plug-in version. Regards, Grégoire
Hi Gregoire, I tested your upgraded version and it now works fine. I will launch the IP process and come back to you if I need more information from your side. Best regards, Hugo
Gregoire and Fabien, Please, could you both make the required confirmation via this bug (same way as in Bug #283604)? Thanks in advance, Best regards, Hugo
I confirm that 1. I, DUPE Grégoire, and others contributors listed in this bug, authored 100% of the content 2. I have the rights to donate the content to Eclipse under the EPL 3. I have already provided the filled Employer Consent Forms to the Foundation Grégoire DUPE.
I confirm that 1. I, GIQUEL Fabien, and others contributors listed in this bug, authored 100% of the content 2. I have the rights to donate the content to Eclipse under the EPL 3. I have already provided the filled Employer Consent Forms to the Foundation Fabien GIQUEL.
Hi guys, Your contribution has been approved and has just been committed onto the MoDisco SVN. Best regards, Hugo
