Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 288384 - ISP Plugin Contribution
Summary: ISP Plugin Contribution
Status: RESOLVED FIXED
Alias: None
Product: PTP
Classification: Tools
Component: Tools (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Greg Watson CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-09-02 13:08 EDT by Alan Humphrey CLA
Modified: 2009-10-19 11:40 EDT (History)
2 users (show)

See Also:


Attachments
Source code (918.64 KB, application/zip)
2009-09-02 13:10 EDT, Alan Humphrey CLA
no flags Details
Source Code 2.0 (1012.50 KB, application/zip)
2009-10-08 12:01 EDT, Chris CLA
no flags Details
Updated ISP plugin projects w/ source code (1015.41 KB, application/zip)
2009-10-18 19:46 EDT, Alan Humphrey CLA
g.watson: iplog+
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Alan Humphrey CLA 2009-09-02 13:08:33 EDT
User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.0.13) Gecko/2009080315 Ubuntu/8.10 (intrepid) Firefox/3.0.13
Build Identifier: 

This plugin is a dynamic formal verification tool for MPI C programs, and was developed at the University of Utah's School of Computing.

Reproducible: Always
Comment 1 Alan Humphrey CLA 2009-09-02 13:10:43 EDT
Created attachment 146300 [details]
Source code

This zip file contains both the ISP plugin and its help project.
Comment 2 Greg Watson CLA 2009-09-16 14:05:43 EDT
Please see the following request from Eclipse legal. Since we submitted this with you and Chris Derrick as authors, you'll both need to do this (including faxing the consent forms.)

>We will require the contributors to make individual confirmations via the
>referenced bugzilla bug confirming the following:
>
>1.  They authored 100% of the content
>2.  They have the rights to donate the content to Eclipse
>3.  They are donating the contribution under the Eclipse Public License
>
>Further since the copyright belongs to the University, we will require a signed
>Employer Consent Form.  Here is the link -
>http://www.eclipse.org/legal/committer_process/employer_consent.pdf.  We
>realize this form is typically used for new committers but we often use it as
>well for contributions.
Comment 3 Alan Humphrey CLA 2009-09-16 15:18:20 EDT
Per the Eclipse legal request:

1.) I Alan Humphrey and Chris Derrick have authored 100% of the contributed code.

2.) I Alan Humphrey have the right to donate the content to Eclipse.

3.) I Alan Humphrey am donating the contribution under the Eclipse Public License. All source code has the Eclipse Foundation Copyright and License Notice included.

-Alan Humphrey


(In reply to comment #2)
> Please see the following request from Eclipse legal. Since we submitted this
> with you and Chris Derrick as authors, you'll both need to do this (including
> faxing the consent forms.)
> 
> >We will require the contributors to make individual confirmations via the
> >referenced bugzilla bug confirming the following:
> >
> >1.  They authored 100% of the content
> >2.  They have the rights to donate the content to Eclipse
> >3.  They are donating the contribution under the Eclipse Public License
> >
> >Further since the copyright belongs to the University, we will require a signed
> >Employer Consent Form.  Here is the link -
> >http://www.eclipse.org/legal/committer_process/employer_consent.pdf.  We
> >realize this form is typically used for new committers but we often use it as
> >well for contributions.
Comment 4 Alan Humphrey CLA 2009-09-16 16:48:20 EDT
Per the Eclipse legal request:

The employer consent form has been filled out for Alan Humphrey and was faxed to Committer Records on 09/16/09 at 14:40 MT.


(In reply to comment #2)
> Please see the following request from Eclipse legal. Since we submitted this
> with you and Chris Derrick as authors, you'll both need to do this (including
> faxing the consent forms.)
> 
> >We will require the contributors to make individual confirmations via the
> >referenced bugzilla bug confirming the following:
> >
> >1.  They authored 100% of the content
> >2.  They have the rights to donate the content to Eclipse
> >3.  They are donating the contribution under the Eclipse Public License
> >
> >Further since the copyright belongs to the University, we will require a signed
> >Employer Consent Form.  Here is the link -
> >http://www.eclipse.org/legal/committer_process/employer_consent.pdf.  We
> >realize this form is typically used for new committers but we often use it as
> >well for contributions.
Comment 5 Chris CLA 2009-09-17 15:29:16 EDT
Per the Eclipse legal request:

1.) I Chris Derrick and Alan Humphrey have authored 100% of the contributed
code.

2.) I Chris Derrick have the right to donate the content to Eclipse.

3.) I Chris Derrick am donating the contribution under the Eclipse Public
License. All source code has the Eclipse Foundation Copyright and License
Notice included.

-Chris Derrick
Comment 6 Greg Watson CLA 2009-10-05 11:40:41 EDT
Alan,

Eclipse legal have spotted links to the Utah legal disclaimer in the HTML documentation. Apparently this should link to the EPL license instead. Would there be any problem with changing this?

Greg
Comment 7 Alan Humphrey CLA 2009-10-05 16:42:45 EDT
Greg,

We've replaced all instances of the links to the University of Utah disclaimer in the ISP Plugin HTML with the EPL at http://www.eclipse.org/org/documents/epl-v10.php.

-Alan


(In reply to comment #6)
> Alan,
> 
> Eclipse legal have spotted links to the Utah legal disclaimer in the HTML
> documentation. Apparently this should link to the EPL license instead. Would
> there be any problem with changing this?
> 
> Greg
Comment 8 Greg Watson CLA 2009-10-08 11:26:45 EDT
Please attach an updated zip file to this bug.

(In reply to comment #7)
> Greg,
> 
> We've replaced all instances of the links to the University of Utah disclaimer
> in the ISP Plugin HTML with the EPL at
> http://www.eclipse.org/org/documents/epl-v10.php.
> 
> -Alan
Comment 9 Greg Watson CLA 2009-10-08 11:33:08 EDT
Can you also add another link to the HTML TOC that points to the Eclipse site first? i.e. something like:

<p>Other related topics:</p>

<ol>
    <li><a href="http://eclipse.org/ptp/isp/">Latest Release of the ISP Eclipse plugin</a>
    <li><a href="http://www.cs.utah.edu/formal_verification/ISP-release/">Latest Release of ISP</a> - Including user manual and test code
    <li><a href="http://www.cs.utah.edu/formal_verification/">Gauss Group Home</a> - All current work and publications
    <li><a href="http://www.cs.utah.edu/">University of Utah School of Computing</a>
</ol>

Eclipse want's to make sure the plugins are obtained from the Eclipse web site.
Comment 10 Chris CLA 2009-10-08 12:01:41 EDT
Created attachment 149131 [details]
Source Code 2.0
Comment 11 Chris CLA 2009-10-08 12:03:25 EDT
(In reply to comment #10)
> Created an attachment (id=149131) [details]
> Source Code 2.0

I have made the requested change to the toc.html, and posted the code with all instances of the links to the University of Utah disclaimer
in the ISP Plugin HTML replaced by the EPL at http://www.eclipse.org/org/documents/epl-v10.php.
Comment 12 Greg Watson CLA 2009-10-15 10:51:48 EDT
Alan,

This submission is now approved subject to the word "Disclaimer" being removed from the HTML files.  Apparently this is not standard wording for Eclipse and legal would prefer if it was changed to simply "license" or just type the href to the EPL in its place.

Also, our practice is to prefix all PTP plugins with org.eclipse.ptp. I think org.eclipse.ptp.isp rather than edu.utah.guass.isp would be fine for yours.

If you could attach the updated plugins to this bug, I'll apply to the CVS head.

Thanks,
Greg
Comment 13 Alan Humphrey CLA 2009-10-18 19:46:39 EDT
Created attachment 149833 [details]
Updated ISP plugin projects w/ source code

This updated zip file contains both the ISP and ISP-Help plugins archived from within Eclipse. All source code packages have been refactored to reflect the org.eclipse.ptp naming convention. Source code and HTML have had the requested changes applied and should conform to what Eclipse Legal has mentioned.
Comment 14 Greg Watson CLA 2009-10-19 11:38:14 EDT
This has now been checked in. I did the following:

1. Reformatted the source files using the "Eclipse" standard formatting.
2. Renamed some class files to remove "_" from the names.
3. Externalized all the strings.
4. Changed the execution environment to J2SE-1.5 instead of JavaSE-1.6 (PTP only requires 1.5). If this is a problem, let me know.
5. Added a feature project. 

Please test that the plugins are still working for you. Also, please update the "description" in features.properties with a description of the plugins The feature plugin is available from CVS in releng/org.eclipse.ptp.isp-feature.

Closing this as completed. I'll open a separate bug on the menu.