Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 287313 - [Menu] Can open two menus at the same time
Summary: [Menu] Can open two menus at the same time
Status: RESOLVED FIXED
Alias: None
Product: RAP
Classification: RT
Component: RWT (show other bugs)
Version: 1.3   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 1.3 M3   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 287314
  Show dependency tree
 
Reported: 2009-08-21 11:19 EDT by Tim Buschtoens CLA
Modified: 2009-10-23 11:19 EDT (History)
1 user (show)

See Also:

Attachments
Solution (26.05 KB, patch)
2009-10-08 08:18 EDT, Tim Buschtoens CLA 		ruediger.herrmann: iplog+
Details | Diff
revised patch (30.86 KB, patch)
2009-10-13 06:32 EDT, Tim Buschtoens CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Buschtoens CLA 2009-08-21 11:19:02 EDT 
It is possible to open a popup-menu and dropdown-menu at the same time: In the controls demo, go to tab "Shell", and create a shell with a menu. Then go to tab "List". Right-click on a list-item, directly after that click on the shells menu-bar.

The source of this problem is probably Qooxdoos menu-manager.
Comment 1 Tim Buschtoens CLA 2009-10-06 11:51:54 EDT 
It also works by opening two shells with menu-bars: Both menu-bars can have an open menu at the same time!
Comment 2 Tim Buschtoens CLA 2009-10-08 08:18:21 EDT 
Created attachment 149104 [details]
Solution

Solves the problem by implementing a new MenuManager, removing qx.ui.menu.Manager.

- Fixes also 287314.
- Files qx.js/qx-debug.js must be rebuild.
- Tests are included.
- This leaves only one class in the qx.ui.menu namespace, "Separator".
Comment 3 Rüdiger Herrmann CLA 2009-10-09 11:40:37 EDT 
Applied patch to CVS HEAD
Comment 4 Rüdiger Herrmann CLA 2009-10-09 12:09:21 EDT 
Reverted changes from patch 'Solution'.
The fix breaks the drop-down menu from the CTabFolder (see ControlsDemo for example). Clicking an item in this menu is just ignored.
Comment 5 Tim Buschtoens CLA 2009-10-13 06:32:18 EDT 
Created attachment 149428 [details]
revised patch

Same patch except:
- Addresses CTabFolder-problem.
- Refactored MenuManager (for legibility)
- More tests
Comment 6 Rüdiger Herrmann CLA 2009-10-23 11:19:46 EDT 
Patch applied to CVS HEAD