Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 286692 - [performance] UI stalls for 2 minutes while in FocusedViewerManager
Summary: [performance] UI stalls for 2 minutes while in FocusedViewerManager
Status: RESOLVED DUPLICATE of bug 267143
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: 3.2   Edit
Hardware: PC Linux
: P3 major (vote)
Target Milestone: ---   Edit
Assignee: Mylyn Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-08-14 19:00 EDT by Jörg Thönnes CLA
Modified: 2009-08-26 09:18 EDT (History)
1 user (show)

See Also:


Attachments
ZIP file with 120 jstack traces done every second during the 2 minute stall (559.99 KB, application/octet-stream)
2009-08-14 19:03 EDT, Jörg Thönnes CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jörg Thönnes CLA 2009-08-14 19:00:22 EDT
Using Mylyn 3.2.1

A colleague noticed considerable UI stalls (about 2 minutes) in the following situation:

1. Task activated
2. Noticed that the wrong task was activate
3. Change active task
4. Insert / delete white space (no-op change) in a file to trigger the correct task-specific changeset comment
5. Save the no-op change

Now Eclipse was blocked for about 2 minutes.

We were able capture a series of jstack stack trace to see which thread was active during the stall.
Please find attached a ZIP file with 120 jstack traces.

The naming pattern of every jstack is "jstack.PID.HHMMSS.nnnnnnn", where HH=hour, MM=minute, SS==second, nnnnnn=nanoseconds.
So you can order the files by name to get the order in time. The snapshots were done every second or less.

I suggest to grep for "FocusedViewerManager" to see occurances in 92 of the 120 files:

bc. 
jstack.26228.133010.905401446:  at org.eclipse.mylyn.internal.context.ui.FocusedViewerManager.updateExpansionState(FocusedViewerManager.java:351)
jstack.26228.133010.905401446:  at org.eclipse.mylyn.internal.context.ui.FocusedViewerManager.access$1(FocusedViewerManager.java:313)
jstack.26228.133010.905401446:  at org.eclipse.mylyn.internal.context.ui.FocusedViewerManager$FocusedViewerDelayedRefreshJob.doRefresh(FocusedViewerManager.java:99)
jstack.26228.133011.733045607:  at org.eclipse.mylyn.internal.context.ui.FocusedViewerManager.updateExpansionState(FocusedViewerManager.java:351)
jstack.26228.133011.733045607:  at org.eclipse.mylyn.internal.context.ui.FocusedViewerManager.access$1(FocusedViewerManager.java:313)
jstack.26228.133011.733045607:  at org.eclipse.mylyn.internal.context.ui.FocusedViewerManager$FocusedViewerDelayedRefreshJob.doRefresh(FocusedViewerManager.java:99)
jstack.26228.133012.610889547:  at org.eclipse.mylyn.internal.context.ui.FocusedViewerManager.updateExpansionState(FocusedViewerManager.java:351)

Only the main thread seems to change. You may also use vimdiff with up to 4 files to see a series of differences nicely.

-- Configuration Details --
Product: Eclipse 1.2.0.20090618-0904 (org.eclipse.epp.package.jee.product)
Installed Features:
 org.eclipse.jdt 3.5.0.v20090527-2000-7r88FEeFJePyvYeA33DjZ_c1
Comment 1 Jörg Thönnes CLA 2009-08-14 19:03:18 EDT
Created attachment 144605 [details]
ZIP file with 120 jstack traces done every second during the 2 minute stall

This ZIP file contains 120 jstack trace done every second during the UI stall. 92 of these files contain the FocusedViewerManager line
and only the main thread changes AFAIK.
Comment 2 Steffen Pingel CLA 2009-08-14 19:54:14 EDT
Shawn, could that be a duplicate of bug 267143?
Comment 3 Jörg Thönnes CLA 2009-08-14 19:57:20 EDT
(In reply to comment #2)
> Shawn, could that be a duplicate of bug 267143?

Hmmm, this looks similiar (though I am not Shanwn of course :-) )

My colleague experiences this roughly once a day so it is rather annoying.
Comment 4 Shawn Minto CLA 2009-08-17 11:58:50 EDT
From looking at the stack traces, it does look like bug 267143.  Jörg, there was a regression that we fixed in 3.2.1 which may be causing this as well.  What version of Mylyn is your colleague using?  If they are using 3.2.0, could you get them to update and see if they still experience the same problem?
Comment 5 Jörg Thönnes CLA 2009-08-19 09:54:18 EDT
(In reply to comment #4)
> From looking at the stack traces, it does look like bug 267143.  Jörg, there was
> a regression that we fixed in 3.2.1 which may be causing this as well.  What
> version of Mylyn is your colleague using?  If they are using 3.2.0, could you
> get them to update and see if they still experience the same problem?

Sorry, but we all are using Eclipse 3.2.1 due to our shared installation. So this issue has not been fixed with 3.2.1
Comment 6 Shawn Minto CLA 2009-08-19 13:08:09 EDT
Thanks for letting us know that this isn't fixed in the latest.  This still does look like a case of bug 267143.  Joerg, do you know how many elements are in your colleagues context that is having this problem?  Also, when this problem happens, do he/she have the context tab of the task editor open or any other views open that are focused?
Comment 7 Jörg Thönnes CLA 2009-08-21 13:15:43 EDT
(In reply to comment #6)
> Thanks for letting us know that this isn't fixed in the latest.  This still does
> look like a case of bug 267143.  Joerg, do you know how many elements are in
> your colleagues context that is having this problem?

No idea, as he is on holiday now.

>  Also, when this problem
> happens, do he/she have the context tab of the task editor open or any other
> views open that are focused?

He was in the Team Perspective, noticed that he had selected the wrong task, switched the task and
made a no-op change (insert/remove space) to a file to trigger the new commit comment from the task.
During the stall, all files in the Team Perspective were selected (marked).
Comment 8 Jörg Thönnes CLA 2009-08-26 09:18:56 EDT
(In reply to comment #5)
> (In reply to comment #4)
> > From looking at the stack traces, it does look like bug 267143.  Jörg, there
> was
> > a regression that we fixed in 3.2.1 which may be causing this as well.  What
> > version of Mylyn is your colleague using?  If they are using 3.2.0, could you
> > get them to update and see if they still experience the same problem?
> 
> Sorry, but we all are using Eclipse 3.2.1 due to our shared installation. So
> this issue has not been fixed with 3.2.1

Sorry, Shawn. I have been mistaken: My colleague actually used an older version of the shared 
installtion with Mylyn 3.2.0 in it. So it is not a regression, but could be well be the mentioned bug.

He updated his installation now and we will report a new bug if it happens again.


*** This bug has been marked as a duplicate of bug 267143 ***