Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 286276 - [ua] [editor] On save help editors remove new items from the table
Summary: [ua] [editor] On save help editors remove new items from the table
Status: VERIFIED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.5   Edit
Hardware: PC Linux
: P3 major (vote)
Target Milestone: 3.6 M2   Edit
Assignee: PDE-UI-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-08-11 12:04 EDT by Michael Rennie CLA
Modified: 2009-09-16 12:46 EDT (History)
2 users (show)

See Also:


Attachments
Patch (9.71 KB, patch)
2009-08-12 03:22 EDT, Ankur Sharma CLA
curtis.windatt.public: iplog+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Rennie CLA 2009-08-11 12:04:29 EDT
I20090809-2000

Using the help contexts editor when I add a new help context and then hit save (Ctrl+S) the new entry vanishes from the table. Inspecting the XML shows that it indeed has been added and it will reappear in the table if I close / reopen the editor or if I add another context.

Steps:

1. open a help context file in the context editor (it also happens in the TOC editor as well)
2. select the root 'contexts' item and press Add Context
3. fill in all three fields with some info
4. hit save (Ctrl+S)

Expected:
the save occurs and I continue on my merry way

Happens:
the new context vanishes from the table - but is actually in the underlying XML
Comment 1 Michael Rennie CLA 2009-08-11 12:05:36 EDT
Just noticed as well that if I try to remove any new keys from the table they come back when I hit save (Ctrl+S)
Comment 2 Curtis Windatt CLA 2009-08-11 12:08:38 EDT
Ankur, this could be from the changes to detect parsing errors.  I wonder if the tree contents are getting cached somewhere and overwriting the current values on save.
Comment 3 Ankur Sharma CLA 2009-08-12 03:22:52 EDT
Created attachment 144188 [details]
Patch

Bad me, silly mistake. Trivial fix - save first, refresh model later.
Comment 4 Curtis Windatt CLA 2009-08-12 12:28:42 EDT
Patch fixes the problems for me, applied to HEAD.
Comment 5 Curtis Windatt CLA 2009-09-16 12:46:17 EDT
Verified.