Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 286182 - [Webapp] Allow additional frame(s) below content frame
Summary: [Webapp] Allow additional frame(s) below content frame
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: User Assistance (show other bugs)
Version: 3.5   Edit
Hardware: PC Windows XP
: P3 enhancement (vote)
Target Milestone: 3.6 M3   Edit
Assignee: Chris Goldthorpe CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 288558
  Show dependency tree
 
Reported: 2009-08-10 17:15 EDT by Chris Goldthorpe CLA
Modified: 2009-10-14 23:47 EDT (History)
1 user (show)

See Also:

Attachments
Patch which implements this extension point (11.13 KB, patch)
2009-08-10 17:17 EDT, Chris Goldthorpe CLA 		no flags Details | Diff
Updated Patch (12.01 KB, patch)
2009-09-09 17:26 EDT, Chris Goldthorpe CLA 		no flags Details | Diff
Plugin which tests this extension point (3.62 KB, application/x-zip-compressed)
2009-09-09 17:30 EDT, Chris Goldthorpe CLA 		no flags Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Goldthorpe CLA 2009-08-10 17:15:04 EDT 
Create an extension point which allows additional frames to be created in the help webapp beneath the content frame. An IBM team has a contribution which I will attach which implements this extension point.
Comment 1 Chris Goldthorpe CLA 2009-08-10 17:17:02 EDT 
Created attachment 143969 [details]
Patch which implements this extension point
Comment 2 Chris Goldthorpe CLA 2009-09-09 17:26:50 EDT 
Created attachment 146818 [details]
Updated Patch

Based on discussions with the original implementors and on my own testing I have made a number of changes to the extension point:

1. The extension point now uses a class instead of attributes.
2. The only place were a frame can be inserted right now is below the content frame, however I have set up the extension point in such a way that it could support more additional frame locations.
3. More than one extra frame is allowed. While we do not recommend adding a lot of extra frames this would support adding a toolbar above an extra frame.
4. The height of the extra frame can be specified.
5. Other frame attributes can also be specified.

At this stage the main outstanding problem is that no sash is showing between the content frame and the extra frame which would allow it to be resized.

I will attach an example plug-in which works with this code.
Comment 3 Chris Goldthorpe CLA 2009-09-09 17:30:23 EDT 
Created attachment 146819 [details]
Plugin which tests this extension point

This plugin adds another copy of the tocToolbar.jsp and tocView.jsp files below the content frame. The new toc view works but the toolbar buttons do not work because of the way the code navigates the frames.
Comment 4 Chris Goldthorpe CLA 2009-09-21 13:30:12 EDT 
Fixed in HEAD.
Comment 5 Hao Zhang CLA 2009-10-14 22:05:15 EDT 
Verified in N20091012-2000.