Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 285590 - [Theming][Button] Support variable size for CHECK and RADIO indicator images
Summary: [Theming][Button] Support variable size for CHECK and RADIO indicator images
Status: RESOLVED FIXED
Alias: None
Product: RAP
Classification: RT
Component: RWT (show other bugs)
Version: 1.3   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: 1.3 M3   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 290510 290518 291175
  Show dependency tree
 
Reported: 2009-08-04 10:19 EDT by Ralf Sternberg CLA
Modified: 2009-10-02 06:26 EDT (History)
2 users (show)

See Also:

Attachments
Fix (3.84 KB, patch)
2009-09-30 10:46 EDT, Tim Buschtoens CLA 		no flags Details | Diff
Fix2 (5.36 KB, patch)
2009-10-01 05:29 EDT, Tim Buschtoens CLA 		ruediger.herrmann: iplog+
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ralf Sternberg CLA 2009-08-04 10:19:17 EDT 
Currently, the images for RADIO and CHECK button indicators must be exactly 13x13 pixels.
Since images sizes are now available on the client (see bug 284801), we can allow variable size.
Comment 1 Benjamin Muskalla CLA 2009-09-16 11:16:17 EDT 
Don't forget to update the description in the Button.theme.xml
Comment 2 Tim Buschtoens CLA 2009-09-30 10:46:40 EDT 
Created attachment 148431 [details]
Fix
Comment 3 Rüdiger Herrmann CLA 2009-09-30 11:39:53 EDT 
(In reply to comment #2)
> Created an attachment (id=148431)
The space reserved for check/radio images in the size computation is still 13 x 13 (see ButtonThemeAdapter#CHECK_SIZE). Thaht would also need to be changed.
Comment 4 Tim Buschtoens CLA 2009-10-01 05:29:03 EDT 
Created attachment 148507 [details]
Fix2

Yep, i didn't look at the ThemeAdapter, only Button itself. Bummer.
This includes the first patch and the changes to ButtonThemeAdpter.
Comment 5 Rüdiger Herrmann CLA 2009-10-01 05:57:54 EDT 
Applied second patch to CVS HEAD