Comment 1 Troy Bishop 2009-08-10 10:39:24 EDT

Created attachment 143917 [details]
possible solution

Comment 2 Troy Bishop 2009-08-10 10:40:14 EDT

Tom,

I am attaching a patch which I think covers your requirements but please let me know if you think otherwise.  The only trace element that is not verified is the line number as that value would change anytime a new line is added or removed from DebugOptionsTestCase.

If you are happy with this patch then please see bug 286130 before committing it as the changes there are required before these tests will succeed.

Comment 3 Thomas Watson 2009-08-10 18:12:17 EDT

Comment on attachment 143917 [details]
possible solution

Thanks Troy!  I will look at this for M2.

Comment 4 Thomas Watson 2009-08-11 18:01:18 EDT

Troy, the patch makes use of the java.lang.StackTraceElement.StackTraceElement(String, String, String, int) constructor which is only part of 1.5.  So far the osgi.tests have only required 1.4.2 and I do run them regularly on that version of the VM.  Is there another approach that could avoid the dependency on JSE 1.5?

Comment 5 Troy Bishop 2009-08-12 10:59:43 EDT

Created attachment 144242 [details]
patch that compiles against a 1.4 JDK

Instead of building the exception I am just creating a new one (new Exception("")), writing it to the trace file, and then ensuring that the it can be read back in, is not null, and that it starts with a pre-defined exception string (rather than comparing the entire contents of the exception).

Comment 6 Thomas Watson 2009-08-12 14:08:17 EDT

Thanks, I released the new tests to HEAD.