Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 285186 - Vendor specific icons not shown in Servers view
Summary: Vendor specific icons not shown in Servers view
Status: RESOLVED FIXED
Alias: None
Product: WTP ServerTools
Classification: WebTools
Component: wst.server (show other bugs)
Version: 3.1   Edit
Hardware: PC Windows Vista
: P3 normal (vote)
Target Milestone: 3.2.2   Edit
Assignee: Angel Vera CLA
QA Contact: Angel Vera CLA
URL:
Whiteboard: ServersView2
Keywords:
: 258650 (view as bug list)
Depends on:
Blocks: 324734
  Show dependency tree
 
Reported: 2009-07-30 12:54 EDT by Kaloyan Raev CLA
Modified: 2017-10-11 16:34 EDT (History)
1 user (show)

See Also:


Attachments
v1.0 (22.00 KB, text/plain)
2010-08-20 14:23 EDT, Angel Vera CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Kaloyan Raev CLA 2009-07-30 12:54:39 EDT
Vendors specific icons in the CNF-based Servers view are shown only when the server's state is UNKNOWN. 

When the server's state changes to something else, e.g. STARTED, then the icons is replaced with an icon of a generic server with a decorator showing the current state. 

I would expect to have the vendor specific icon all the time and a decorator over it showing the current state.
Comment 1 Angel Vera CLA 2009-07-30 13:54:07 EDT
We wanted to get this for 3.1 but it became to risky to change during shutdown. The current behaviour is that we use the old state icon, but because the state icon comes with the server, not only the play/stoppped icon, the full image gets overwritten. 

Definitely something that we want to fix. 
Comment 2 Angel Vera CLA 2009-08-24 17:23:27 EDT
Moving out to 3.1.2, we don't have time to fix this minor UI problem, in 3.1.1
Comment 3 Angel Vera CLA 2009-11-09 14:20:40 EST
We have to create a new icon for this to work correctly. I rather leave the 3.1 functionality as it is, and come up with something for 3.2.
Comment 4 Rob Stryker CLA 2010-04-01 04:39:15 EDT
*** Bug 258650 has been marked as a duplicate of this bug. ***
Comment 5 Angel Vera CLA 2010-08-20 14:23:58 EDT
Created attachment 177128 [details]
v1.0

This code works, but I would like to do improvements on it later. With this code we are overlaying the state icon using the ServerLabelDecorator that is by default on the view, but I would prefer that we do it using the ServerDecorator. So that the image turns off automaticaly with the decorator.
Comment 6 Angel Vera CLA 2010-08-20 15:27:28 EDT
Changes committed to 32M and released to 32M
Comment 7 Angel Vera CLA 2010-08-20 15:31:44 EDT
Changes committed to HEAD and released to HEAD
Comment 8 Angel Vera CLA 2010-08-20 15:34:19 EDT
To clarify comment #5. ServerLabelDecorator will be the default class that provides the server adopter provided image to the view. That class will also be the one responsible for overlaying the icon. The overlay is what I will be improving on later, so that the overlay is done by the ServerDecorator class, which is the class that provides the state and status text for the view.
Comment 9 Angel Vera CLA 2010-08-26 14:15:59 EDT
fixed
Comment 10 Eclipse Genie CLA 2017-10-11 16:34:25 EDT
New Gerrit change created: https://git.eclipse.org/r/108978