Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 285134 - Table of Contents Editor does not recognize single quotes
Summary: Table of Contents Editor does not recognize single quotes
Status: RESOLVED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.5   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.6 M2   Edit
Assignee: Curtis Windatt CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-07-30 06:17 EDT by Udo Walker CLA
Modified: 2009-08-10 12:52 EDT (History)
3 users (show)

See Also:

Attachments
Patch (3.66 KB, patch)
2009-08-04 16:03 EDT, Ankur Sharma CLA 		curtis.windatt.public: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Udo Walker CLA 2009-07-30 06:17:23 EDT 
Build ID: 20090619-0625

Steps To Reproduce:
If the attributes of the <toc> entries use single quotes then no text is shown.


More information:
Check this example:
<toc label='Doc' topic='index.html'>
  <topic label='toc' href='toc.html'/>
  <topic label='Index' href='index.html'/>
</toc>

You will see the structure of the file in the editor but not the contents of the attributes.
Comment 1 Ankur Sharma CLA 2009-07-30 10:17:05 EDT 
am looking into this one.
Comment 2 Curtis Windatt CLA 2009-07-30 10:19:28 EDT 
(In reply to comment #1)
> am looking into this one.
> 

Cool.  Marking as M2 as we have other commitments for M1.
Comment 3 Ankur Sharma CLA 2009-08-04 16:03:48 EDT 
Created attachment 143443 [details]
Patch

Corrected the regular expression to consider single quote too.
Added test cases for plugin.xml and cheatsheet. Adding for ctx help and toc might be overkill for this small change.
Comment 4 Curtis Windatt CLA 2009-08-04 16:31:17 EDT 
I'll review the patch.  Thanks Ankur.
Comment 5 Curtis Windatt CLA 2009-08-10 12:52:08 EDT 
Works great, tests pass.  Fixed in HEAD.