Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 284806 - NativeCodeSpecification resolution errors incorrectly reported
Summary: NativeCodeSpecification resolution errors incorrectly reported
Status: RESOLVED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: Build (show other bugs)
Version: 3.5   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.6 M1   Edit
Assignee: pde-build-inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-07-27 17:38 EDT by Andrew Niefer CLA
Modified: 2009-07-30 14:45 EDT (History)
1 user (show)

See Also:

Attachments
patch (13.72 KB, patch)
2009-07-29 18:13 EDT, Andrew Niefer CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Niefer CLA 2009-07-27 17:38:27 EDT 
If a bundle fails to resolve and the unsatisfied constraint is a NativeCodeSpecification, then we end up reporting a misleading error message:

 Bundle org.eclipse.swt.carbon.macosx:
	Host plug-in Bundle-NativeCode_0.0.0 has not been found.
Comment 1 Andrew Niefer CLA 2009-07-27 18:41:42 EDT 
As part of this, we need to be able to ignore resolution errors that are caused by filters not matching if we aren't building for that platform.
Comment 2 Andrew Niefer CLA 2009-07-29 18:13:51 EDT 
Created attachment 142958 [details]
patch

Patch fixes logging around Bundle-NativeCode.

Tom, can you look at BundleHelper.getFilter(BundleDescription)
It creates a filter by combining the Eclipse-PlatformFilter with the Bundle-NativeCode selection-filters.  It assumes each filter string is surrounded with '(' ')'.

Once this is in, I will start looking at bug 284784 by replacing calls to BundleDescription.getPlatformFilter() with this getFilter.
Comment 3 Thomas Watson CLA 2009-07-30 12:26:16 EDT 
(In reply to comment #2)
> Tom, can you look at BundleHelper.getFilter(BundleDescription)
> It creates a filter by combining the Eclipse-PlatformFilter with the
> Bundle-NativeCode selection-filters.  It assumes each filter string is
> surrounded with '(' ')'.
> 

This looks good.  It is valid to assume each filter string is surrounded with '(' ')'

> Once this is in, I will start looking at bug 284784 by replacing calls to
> BundleDescription.getPlatformFilter() with this getFilter.
> 

This patch seems to do part of this already.  I guess that is just enough to get a good Bundle-NativeCode resolution errors?
Comment 4 Andrew Niefer CLA 2009-07-30 14:45:11 EDT 
(In reply to comment #3)
> This patch seems to do part of this already.  I guess that is just enough to
> get a good Bundle-NativeCode resolution errors?
> 

Yes, we don't report errors on bundles that were only unresolved because they didn't match one of the configs (os,ws,arch) that we are building.

I have released this patch to 3.6 head