Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 284155 - support overlay of product and component on attributes section header
Summary: support overlay of product and component on attributes section header
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows Vista
: P3 enhancement (vote)
Target Milestone: 3.3   Edit
Assignee: Mik Kersten CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 278323
Blocks: 290616
  Show dependency tree
 
Reported: 2009-07-21 12:46 EDT by David Shepherd CLA
Modified: 2009-10-08 02:00 EDT (History)
3 users (show)

See Also:


Attachments
patch (3.94 KB, patch)
2009-07-24 00:15 EDT, Mik Kersten CLA
no flags Details | Diff
label on Gtk (1.16 KB, image/png)
2009-08-07 14:29 EDT, Steffen Pingel CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description David Shepherd CLA 2009-07-21 12:46:09 EDT
When the attributes section is collapsed there is still several pieces of information that it would be helpful to have visible.  Chief among these are the product and component.  It would be great to see the value of these attributes (only) when the section is collapsed.  It would also be nice for other sections to be able to contribute summary information to the section headers in a generic way.
Comment 1 Mik Kersten CLA 2009-07-23 20:09:33 EDT
+1
Comment 2 Mik Kersten CLA 2009-07-24 00:15:39 EDT
Created attachment 142477 [details]
patch
Comment 3 Mik Kersten CLA 2009-07-24 00:16:15 EDT
I realized that this would ease my Mylyn bug triage process sufficiently that I went ahead and added it.

Steffen: Please review carefully as I'm not very familiar with this part of the codebase.  Once again this is in a gray area between 3.2.2 and 3.3 so we'll have to decide on that, and I've attached a patch in case we roll back.  We'll also need to make sure that this does something reasonable for other connectors which provide the product/component attributes, since it will automatically work for all that do.
Comment 4 Steffen Pingel CLA 2009-07-24 05:30:01 EDT
I have reverted the patch as it adds API and violates the conventions that we use for versioning. I'll go ahead and create a maintenance branch for 3.2.2 so you we can reconsider. Please note the patch will show ids instead of values for JIRA for instance. Why don't you apply the change to your bootstrap workspace if you want to levarage the functionality for your bug triage?

Please always tag bug that add [api] as API and I would generally prefer if changes to the core part of the task editor API were discussed first.
Comment 5 Mik Kersten CLA 2009-07-28 19:59:38 EDT
Committed with fixes to get the attributes from the model.

Please try this out.  We can improve on this further once we get more into the mapping.
Comment 6 Steffen Pingel CLA 2009-08-07 14:28:14 EDT
I have fixed the labels for JIRA which was still showing numeric ids. 

What I find a bit strange is that the labels show the product / component that was selected on task open but do not change as I edit attributes. In terms of API I believe a setInfoOverlayText() method that would allow updating of the text would be more suitable than the current implemetation that requires overriding of getInfoOverlayText(). 

Note that the alignment on Linux is slightly out of place (see screenshot).
Comment 7 Steffen Pingel CLA 2009-08-07 14:29:52 EDT
Created attachment 143794 [details]
label on Gtk

It might look better if the label is vertically centered in relation to the toolbar.
Comment 8 Steffen Pingel CLA 2009-10-08 02:00:05 EDT
I don't feel comfortable making this API just yet. The main problem is that the new API assumes that AbstractTaskEditorPart uses sets a section which is not necessarily the case. Due to that limitation it would be overly complicated to allow clients to update the label etc. I have moved the code into a new internal class AbstractTaskEditorSection for now that will allow us to stabilize the API and get rid of some of the code duplication in the editor parts that we have accumulated over the past few releases.