Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 284101 - Activate first child in SubModule automatically
Summary: Activate first child in SubModule automatically
Status: RESOLVED FIXED
Alias: None
Product: Riena
Classification: RT
Component: navigation (show other bugs)
Version: unspecified   Edit
Hardware: PC All
: P3 normal (vote)
Target Milestone: 1.2.0.M1   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-07-21 04:55 EDT by Steffen Kriese CLA
Modified: 2011-05-19 07:01 EDT (History)
1 user (show)

See Also:


Attachments
Added setSelectable in ISubModuleNode (11.07 KB, patch)
2009-07-21 04:57 EDT, Steffen Kriese CLA
no flags Details | Diff
Patch with additional unittests (13.43 KB, patch)
2009-07-21 07:30 EDT, Steffen Kriese CLA
no flags Details | Diff
Uses new DefaultValue Annotation API (13.40 KB, patch)
2009-07-22 02:37 EDT, Steffen Kriese CLA
no flags Details | Diff
throws RuntimeException if node with selectable = false without children gets selected (13.01 KB, patch)
2009-07-22 07:55 EDT, Steffen Kriese CLA
christian.campo: iplog+
Details | Diff
Example showing selectable SubModules in SwtExampleClient (11.36 KB, patch)
2009-07-22 09:23 EDT, Steffen Kriese CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Steffen Kriese CLA 2009-07-21 04:55:43 EDT
In ISubmoduleNode should be a flag (setSelectable) indicating if this SubmoduleNode is selectable. If it is not selectable and the SubmoduleNode has at least one child and this node is selected, then the first child should be selected instead. The default value should be true, so existing code does not break.
If selectable is true the developer does not have to provide a SubmoduleView or SubmoduleController, because it isn't used anyway.
Comment 1 Steffen Kriese CLA 2009-07-21 04:57:13 EDT
Created attachment 142105 [details]
Added setSelectable in ISubModuleNode
Comment 2 Steffen Kriese CLA 2009-07-21 07:30:56 EDT
Created attachment 142115 [details]
Patch with additional unittests
Comment 3 Steffen Kriese CLA 2009-07-22 02:37:00 EDT
Created attachment 142220 [details]
Uses new DefaultValue Annotation API
Comment 4 Steffen Kriese CLA 2009-07-22 07:55:10 EDT
Created attachment 142251 [details]
throws RuntimeException if node with selectable = false without children gets selected
Comment 5 Steffen Kriese CLA 2009-07-22 09:23:37 EDT
Created attachment 142263 [details]
Example showing selectable SubModules in SwtExampleClient
Comment 6 Christian Campo CLA 2009-07-22 12:08:25 EDT
I will commit the patch for the solution and for the example, how the feature is not complete yet. If you click on a not selectable module, the child is selected, if you click on the same module again, the module is actually selected in the try although the workarea remains unchanged.
Comment 7 Nobody - feel free to take it CLA 2009-07-24 09:22:53 EDT
We don´t need any logic for this in the NavigationProcessor. Simplest way to do this is in the SubModuleNode.