Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 284026 - [upstream] support creating private comments and attachments
Summary: [upstream] support creating private comments and attachments
Status: CLOSED MOVED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P2 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Frank Becker CLA
QA Contact:
URL: https://bugzilla.mozilla.org/show_bug...
Whiteboard:
Keywords:
: 342109 (view as bug list)
Depends on: 345847
Blocks: 347718 349770
  Show dependency tree
 
Reported: 2009-07-20 11:45 EDT by Shawn Minto CLA
Modified: 2012-05-23 06:40 EDT (History)
6 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Shawn Minto CLA 2009-07-20 11:45:16 EDT
You can can setup bugzilla to support private comments and attachments.  It would be useful to be able to create a private comment or attachment from within the bugzilla connector.  This can be setup by setting a group for the insidergroup in the Group Security settings.
Comment 1 Frank Becker CLA 2009-11-04 17:06:37 EST
Actual I see no way to get this without an enhancement in Bugzilla.

There is no way to get the Info if an user is in the insidergroup. Should we open an bug for this in bugzilla?

Do you want this in config.cgi?ctype=rdf or should we use this over an webservice?
Comment 2 Mik Kersten CLA 2009-11-05 12:56:32 EST
+1 this would be great to see
Comment 3 Robert Elves CLA 2009-11-05 13:34:23 EST
Frank, if feasible, it makes sense to try to get this into the rdf for the short term, then we can look at inclusion in the web service later. If this makes sense, go ahead and file a bug against bugzilla and throw me on the cc. Depending on release timing, we may be able to make this happen for 3.4.
Comment 4 Frank Becker CLA 2009-11-06 17:17:15 EST
(In reply to comment #3)
> Frank, if feasible, it makes sense to try to get this into the rdf for the
> short term, then we can look at inclusion in the web service later. If this
> makes sense, go ahead and file a bug against bugzilla and throw me on the cc.
> Depending on release timing, we may be able to make this happen for 3.4.

I create an bug which was marked as duplicate of https://bugzilla.mozilla.org/show_bug.cgi?id=449139.

Patch V4 include the information we need for this fix.
Comment 5 Robert Elves CLA 2009-11-06 21:04:39 EST
Great!
Comment 6 Steffen Pingel CLA 2010-01-09 16:48:33 EST
Rob, why is this scheduled for 3.4? As far as I can tell this is still waiting on upstream Bugzilla changes.
Comment 7 Robert Elves CLA 2010-01-19 16:27:36 EST
I think we'd like to keep it on that target in hopes that your patch gets accepted.
Comment 8 Steffen Pingel CLA 2010-04-29 21:09:11 EDT
Ok. Then let's hope there is some progress on the Bugzilla end in the next four weeks. We'll need to get this in by May 26th or postpone to the next release.
Comment 9 Steffen Pingel CLA 2011-02-05 16:31:32 EST
Frank, can you ping on the Bugzilla bug? It looks like your latest patch is still awaiting review.
Comment 10 Frank Becker CLA 2011-02-15 15:41:08 EST
(In reply to comment #9)
> Frank, can you ping on the Bugzilla bug? It looks like your latest patch is
> still awaiting review.

Done!

Hope tht we have the fix for 3.6.
Comment 11 Steffen Pingel CLA 2011-04-07 04:51:56 EDT
*** Bug 342109 has been marked as a duplicate of this bug. ***
Comment 12 Xavier Sanz CLA 2011-04-07 09:48:22 EDT
Hello,

Ok , I've updated to Bugzilla 3.6.4, and now I can see private comments on Eclipse/Mylyn... 

But in task edition I cannot enter private comment. Also private comments doesn't not distinguish from non-private ones.

Could u make them distinguishable?
Comment 13 Steffen Pingel CLA 2011-05-21 14:04:36 EDT
Frank, what is the status of this bug?
Comment 14 Frank Becker CLA 2011-05-22 02:59:25 EDT
(In reply to comment #13)
> Frank, what is the status of this bug?

I can now start with this.

Should I do

1) But we can only create private comments if the bug already has at least one private comment.
I think this is the same for attachments.

or

2) Or should we create an checkbox in the Repository Settings Dialog under Additional Settings so an user can set this if he know that he is in the insidergroup.

I would prefer 2)

Thoughts?
Comment 15 Steffen Pingel CLA 2011-05-28 11:05:26 EDT
(2) sounds good to me. We should also file a bug against Bugzilla to provide remote API for detecting the ability to submit private comments. Since we are already close to RC3 is it okay if we move this bug to 3.7?
Comment 16 Frank Becker CLA 2011-05-29 02:27:26 EDT
(In reply to comment #15)
> (2) sounds good to me. We should also file a bug against Bugzilla to provide
> remote API for detecting the ability to submit private comments. Since we are
> already close to RC3 is it okay if we move this bug to 3.7?

+1 for move to 3.7

Shawn what do you think?
Comment 17 Steffen Pingel CLA 2011-09-28 08:51:30 EDT
Frank, can you summarize the status of this bug?
Comment 18 Frank Becker CLA 2011-10-01 09:15:40 EDT
I create an checkbox in the Repository Settings Dialog under Additional Settings so an user can set this if he know that he is in the insider group.

(In reply to comment #17)
> Frank, can you summarize the status of this bug?

Here is what we have:
* support for toggle the is_private for comments
* support for creating private comments

What we need:
* add support for attachments
* add comment actions to context menu
* create an Bugzilla enhancement but to include the local comment number in the xml and webservice API

Until we have the local comment number we have the following problem.

If an user is not in the insider group and look into an task with private comments we can not generate the correct "(In reply to comment # <local comment number>). This is the reason for the   Bugzilla enhancement.
Comment 19 Frank Becker CLA 2011-10-01 15:10:15 EDT
https://bugzilla.mozilla.org/show_bug.cgi?id=675502 is the bug for the xml request
https://bugzilla.mozilla.org/show_bug.cgi?id=675517 is for the webservice and is already fixed!

As part of bug# 354023 we can fix this
Comment 20 Steffen Pingel CLA 2011-10-05 15:43:00 EDT
Thanks for the great summary! If we can avoid depending on XML-RPC this would be preferable since it's not enabled on all Bugzilla instances.
Comment 21 Steffen Pingel CLA 2012-02-09 19:38:31 EST
(In reply to comment #18)
> What we need:
> * add support for attachments

Tracked on bug 347718. We can do that at a later time.

> * add comment actions to context menu

Nice to have but we don't need to worry about this now.

> * create an Bugzilla enhancement but to include the local comment number in the
> xml and webservice API

Can we consume the new Bugzilla API now?
Comment 22 Frank Becker CLA 2012-03-23 14:37:34 EDT
(In reply to comment #21)
> (In reply to comment #18)
> > What we need:
> > * add support for attachments
> 
> Tracked on bug 347718. We can do that at a later time.
> 
> > * add comment actions to context menu
> 
> Nice to have but we don't need to worry about this now.
> 
> > * create an Bugzilla enhancement but to include the local comment number in the
> > xml and webservice API
> 
> Can we consume the new Bugzilla API now?

Only the bug for the webservice is solved, maybe you should comment/vote on https://bugzilla.mozilla.org/show_bug.cgi?id=675502
Comment 23 Eclipse Webmaster CLA 2022-11-15 11:45:08 EST
Mylyn has been restructured, and our issue tracking has moved to GitHub [1].

We are closing ~14K Bugzilla issues to give the new team a fresh start. If you feel that this issue is still relevant, please create a new one on GitHub.

[1] https://github.com/orgs/eclipse-mylyn