Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 283823 - [plug-in registry] simplify r-osgi ports configuration
Summary: [plug-in registry] simplify r-osgi ports configuration
Status: RESOLVED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: Incubators (show other bugs)
Version: 3.5   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: PDE-Incubator-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 274982
  Show dependency tree
 
Reported: 2009-07-17 06:34 EDT by Jacek Pospychala CLA
Modified: 2009-08-05 05:46 EDT (History)
1 user (show)

See Also:


Attachments
adds ports configuration (8.26 KB, patch)
2009-07-17 09:21 EDT, Wojciech Galanciak CLA
no flags Details | Diff
updated addresses configuration (8.10 KB, patch)
2009-07-20 09:35 EDT, Wojciech Galanciak CLA
jacek.pospychala: iplog+
Details | Diff
additional patch (3.67 KB, patch)
2009-07-22 08:17 EDT, Wojciech Galanciak CLA
jacek.pospychala: iplog+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jacek Pospychala CLA 2009-07-17 06:34:35 EDT
When setting up connection between Plug-in Registry and some remote application, user should be able to use simple URL, like "r-osgi://localhost:port".

On the server side, monitoring plug-in should use some default port (r-osgi default is fine), but it should be also easy to configure it to use some other port.
Comment 1 Wojciech Galanciak CLA 2009-07-17 09:21:19 EDT
Created attachment 141883 [details]
adds ports configuration

This patch modifies:
- org.eclipse.pde.runtime - adds backend.setURI(uri) call in RegistryModelFactory
- org.eclipse.pde.runtime.core - adds new method setURI in RegistryBackend interface
- org.eclipse.pde.runtime.rosgi.rs

To change client address you must set fallowing properties:
- ch.ethz.iks.r_osgi.port - default is 9278
- rosgi.client.host - default is localhost
Comment 2 Wojciech Galanciak CLA 2009-07-17 09:40:29 EDT
Of course you must set these properties in the client application.
Comment 3 Wojciech Galanciak CLA 2009-07-20 09:35:21 EDT
Created attachment 142012 [details]
updated addresses configuration

It's updated version of previous patch. Now if you want to connect with remote application you must only know its ip address and port. Client application will get its host address and rosgi port automaticly. Of course you can still change ports of rosgi instances on both sides by using property ch.ethz.iks.r_osgi.port.
Comment 4 Jacek Pospychala CLA 2009-07-21 02:27:13 EDT
Patch looks good :-)

FIXED
Comment 5 Wojciech Galanciak CLA 2009-07-22 08:17:02 EDT
Created attachment 142253 [details]
additional patch

I forgot to add changes in org.eclipe.pde.runtime.RegistryModelFactory, org.eclipe.pde.runtime.core.LocalRegistryBackend and org.eclipse.pde.runtime.core.RegistryBackend to previous patch. They are required.
Comment 6 Jacek Pospychala CLA 2009-08-05 05:46:17 EDT
not sure why I didn't marked as FIXED on 2009-07-21...
it's FIXED since then with both Wojciech patches applied.