Community
Participate
Working Groups
Several issues with datapool table multi-row (records) selection. The following issues exist with multi-row (records) selection in the datapool table (see 252958): 1) With a datapool with more rows (e.g. >100) than displayed (e.g. scroll bars), selecting multi-rows (pressing the down arrow while the Shift or Ctrl key is pressed) i) only the selected cell in the first column changes once the cursor is moved past the bottom of the page, ii) the view does not scroll (cells and scroll bar) once the cursor is moved past the bottom of the page, and iii) the last row cannot be selected. 2) When moving and editing multiples rows, only the selected row (row for the cell with the dotted outline) is moved/edited. 3) Deleting or removing multiple rows is supported but the label on action singular (e.g. Record). 4) Individual cells cannot be multi-selected. 5) A single cell is selected (blue shading with dotted border) when selecting multiple rows (see the behavior in http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.swt.snippets/src/org/eclipse/swt/snippets/Snippet96.java?view=co). 6) Implement the 'Selected Lines' option in the Find/Replace dialog (see https://bugs.eclipse.org/bugs/show_bug.cgi?id=173653) 7) Correct the implementation of org.eclipse.hyades.test.ui.datapool.internal.control.DatapoolTable.getSelectedCells() (currently only a single cell is returned). 8) When selecting multiple rows, the record context menus appear when right-clicking any of the selected cells. 9) Page up/down (also using the mouse), home/end (also using the mouse), enter with the shift or ctrl keys pressed do not multi-select properly. 10) After selecting multiple (e.g. 3) rows, holding the Ctrl key and clicking one of the previously selected rows (e.g. middle) with the mouse, the cell in the first row/column is selected. Also, after selecting multiple (e.g. 3) rows, the last row cannot be deselected by holding the Ctrl key and clicking the first column in the last row with the mouse. 11) Selection and multi-selection is quirky in the Datapool Editor. Clicking (left or right mouse buttons) a single cell (including the row number cells in the first column) will select the cell (dotted outline) but also highlight the row (including the row number cell in the first column) excluding the selected cell. Holding the Shift or Ctrl keys while clicking (only left mouse button) cells (including the row number cells in the first column) will select the cell (dotted outline) and multi-select (highlight) the row (including the row number cell in the first column) excluding the selected cell. Interestingly, when multiple cells (actually rows) are selected and holding the Shift or Ctrl keys while clicking one of the selected rows causes the row to be deselected, but the first cell in the selected column is selected (dotted outline).
*** Bug 257623 has been marked as a duplicate of this bug. ***
Requires changes to /org.eclipse.hyades.test.doc.user/concepts/cdatapooleditor.htm to reflect the issues resolved by this defect.
Created attachment 141799 [details] Partial Patch.
(In reply to comment #0) > Several issues with datapool table multi-row (records) selection. > > The following issues exist with multi-row (records) selection in the datapool > table (see 252958): > > 1) With a datapool with more rows (e.g. >100) than displayed (e.g. scroll > bars), selecting multi-rows (pressing the down arrow while the Shift or Ctrl > key is pressed) i) only the selected cell in the first column changes once the > cursor is moved past the bottom of the page, ii) the view does not scroll > (cells and scroll bar) once the cursor is moved past the bottom of the page, > and iii) the last row cannot be selected. See https://bugs.eclipse.org/bugs/show_bug.cgi?id=29950.
12) Selecting all of the rows and right-clicking selects the row/cell where the context menu was opened, giving the impression that context menu actions are specific to that row/cell, when all of the cells are selected. 13) Selecting all of the rows and deleting only deletes the currently selected row/cell, when all of the cells are selected.
14) When multi-selecting using the Home/End/PgUp/PgDn keys, only the first and last cells are selected.
(In reply to comment #0) > 4) Individual cells cannot be multi-selected. The SWT Team (contact: Grant Gayed) has confirmed that the SWT Table/TableCursor widgets are not suitable for 'spreadsheet' style of applications, since the native operating system table control does not provide this functionality (see https://bugs.eclipse.org/bugs/show_bug.cgi?id=146541#c1. Instead, consider using the Grid widget (http://www.eclipse.org/nebula/widgets/grid/grid.php) in the Nebula Project (http://www.eclipse.org/nebula/). Given the lack of Test Project resources and the investment to refactor the /org.eclipse.hyades.test.ui/src/org/eclipse/hyades/test/ui/datapool/internal/control/DatapoolTable.java to a Nebula Project Grid widget, we will not implement this requirement.
Created attachment 162877 [details] Patch.
> Several issues with datapool table multi-row (records) selection. > > The following issues exist with multi-row (records) selection in the datapool > table (see 252958): > > 1) With a datapool with more rows (e.g. >100) than displayed (e.g. scroll > bars), selecting multi-rows (pressing the down arrow while the Shift or Ctrl > key is pressed) i) only the selected cell in the first column changes once the > cursor is moved past the bottom of the page, ii) the view does not scroll > (cells and scroll bar) once the cursor is moved past the bottom of the page, > and iii) the last row cannot be selected. Resolved in the attached patch. > 2) When moving and editing multiples rows, only the selected row (row for the > cell with the dotted outline) is moved/edited. Disabled moving/editing multiple records in the attached patch. > 3) Deleting or removing multiple rows is supported but the label on action > singular (e.g. Record). Resolved in the attached patch. > 4) Individual cells cannot be multi-selected. See comment 7. > 5) A single cell is selected (blue shading with dotted border) when selecting > multiple rows (see the behavior in > http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.swt.snippets/src/org/eclipse/swt/snippets/Snippet96.java?view=co). Resolved in the attached patch. > 6) Implement the 'Selected Lines' option in the > Find/Replace dialog (see https://bugs.eclipse.org/bugs/show_bug.cgi?id=173653) Resolved in the attached patch. > 7) Correct the implementation of > org.eclipse.hyades.test.ui.datapool.internal.control.DatapoolTable.getSelectedCells() > (currently only a single cell is returned). Removed since internal method was no longer required. > 8) When selecting multiple rows, the record context menus appear when > right-clicking any of the selected cells. Resolved in the attached patch. > 9) Page up/down (also using the mouse), home/end (also using the mouse), enter > with the shift or ctrl keys pressed do not multi-select properly. Resolved in the attached patch. > 10) After selecting multiple (e.g. 3) rows, holding the Ctrl key and clicking > one of the previously selected rows (e.g. middle) with the mouse, the cell in > the first row/column is selected. Also, after selecting multiple (e.g. 3) > rows, the last row cannot be deselected by holding the Ctrl key and clicking > the first column in the last row with the mouse. Resolved in the attached patch. > 11) Selection and multi-selection is quirky in the Datapool Editor. Clicking > (left > or right mouse buttons) a single cell (including the row number cells in the > first column) will select the cell (dotted outline) but also highlight the row > (including the row number cell in the first column) excluding the selected > cell. Holding the Shift or Ctrl keys while clicking (only left mouse button) > cells (including the row number cells in the first column) will select the cell > (dotted outline) and multi-select (highlight) the row (including the row number > cell in the first column) excluding the selected cell. Interestingly, when > multiple cells (actually rows) are selected and holding the Shift or Ctrl keys > while clicking one of the selected rows causes the row to be deselected, but > the first cell in the selected column is selected (dotted outline). Resolved in the attached patch. > 12) Selecting all of the rows and right-clicking selects the row/cell where the > context menu was opened, giving the impression that context menu actions are > specific to that row/cell, when all of the cells are selected. Resolved what context menus are enabled in the attached patch. > 13) Selecting all of the rows and deleting only deletes the currently selected > row/cell, when all of the cells are selected. Resolved in the attached patch. > 14) When multi-selecting using the Home/End/PgUp/PgDn keys, only the first and > last cells are selected. Resolved in the attached patch. > Requires changes to > /org.eclipse.hyades.test.doc.user/concepts/cdatapooleditor.htm to reflect the > issues resolved by this defect. Resolved in the attached patch. Five new test cases added to /org.eclipse.hyades.test.ui.datapool.tests/manual/datapool/Test.UI.DatapoolEditor_editing.testsuite. The attached patch is checked in to CVS (HEAD).
Verified in TPTP-4.7.0-201003251321. Closing.
