Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 283595 - defaultProgressManager leaking jobs
Summary: defaultProgressManager leaking jobs
Status: RESOLVED FIXED
Alias: None
Product: RAP
Classification: RT
Component: Workbench (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P1 normal (vote)
Target Milestone: 1.3 M2   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-07-15 13:27 EDT by Ian Bull CLA
Modified: 2009-09-14 08:04 EDT (History)
0 users

See Also:

Attachments
Patch (2.09 KB, patch)
2009-07-15 13:29 EDT, Ian Bull CLA 		ruediger.herrmann: iplog+
Details | Diff
snippet (12.09 KB, application/octet-stream)
2009-09-10 17:55 EDT, Benjamin Muskalla CLA 		no flags Details
Updated patch to match HEAD (1.84 KB, patch)
2009-09-11 12:51 EDT, Rüdiger Herrmann CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ian Bull CLA 2009-07-15 13:27:18 EDT 
The defaultProgressManager never cleans up jobs.  It appears that when no display is set, the done() notification is never sent when jobs are completed.
Comment 1 Ian Bull CLA 2009-07-15 13:29:19 EDT 
Created attachment 141678 [details]
Patch

Here is the patch tha Benny and I worked on.
Comment 2 Benjamin Muskalla CLA 2009-09-10 17:55:58 EDT 
Created attachment 146914 [details]
snippet

And a small demo.
Start the demo, the job runs, refresh before the UI job gets triggered
Comment 3 Rüdiger Herrmann CLA 2009-09-11 12:51:40 EDT 
Created attachment 146967 [details]
Updated patch to match HEAD
Comment 4 Rüdiger Herrmann CLA 2009-09-14 08:04:30 EDT 
Thanks Ian! Applied patch to CVS HEAD.