Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 283383 - Reader component should have fault tolerant mode
Summary: Reader component should have fault tolerant mode
Status: RESOLVED FIXED
Alias: None
Product: EMFT
Classification: Modeling
Component: MWE (show other bugs)
Version: 0.7.1   Edit
Hardware: PC Linux
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 282957
  Show dependency tree
 
Reported: 2009-07-14 04:44 EDT by Achim Demelt CLA
Modified: 2010-05-27 07:51 EDT (History)
2 users (show)

See Also:

Attachments
Proposed patch (6.44 KB, patch)
2009-07-14 04:52 EDT, Achim Demelt CLA 		sven.efftinge: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Achim Demelt CLA 2009-07-14 04:44:33 EDT 
To implement incremental generation for Xpand (see bug #282957), we need to read files that may not exist. Currently, the Reader workflow component throws an exception and aborts the workflow. In our case, however, we can proceed with a normal (non-incremental) generation.

I suggest an additional parameter "ignoreMissingModel" for the compnent. It defaults to false, thus maintaining its current behavior. If set to true, the Reader will ignore I/O errors and simply return a null model.
Comment 1 Achim Demelt CLA 2009-07-14 04:52:19 EDT 
Created attachment 141488 [details]
Proposed patch

This patch implements the suggested changes. Test case included.

The diff for the test case looks a bit strange in the patch file. I don't know why it got messed up and if it can be applied correctly. Maybe some Windows/Linux file encoding issues?
Comment 2 Sebastian Zarnekow CLA 2009-08-13 02:14:55 EDT 
Patch applied. Thanks.