This Bugzilla instance is deprecated, and most Eclipse projects now use GitHub or Eclipse GitLab. Please see the deprecation plan for details.
Bug 283182 - [Compatibility] Variables need to be made available to the handlers
Summary: [Compatibility] Variables need to be made available to the handlers
Status: RESOLVED FIXED
Alias: None
Product: e4
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 0.9   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 0.9 RC2   Edit
Assignee: Paul Webster CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-07-10 15:04 EDT by Paul Webster CLA
Modified: 2009-07-26 11:04 EDT (History)
2 users (show)

See Also:

Attachments
Legacy handler service and show in v01 (2.74 KB, patch)
2009-07-16 11:28 EDT, Paul Webster CLA 		no flags Details | Diff
active menu variables v01 (3.23 KB, patch)
2009-07-17 14:31 EDT, Paul Webster CLA 		no flags Details | Diff
active menu variables v02 (7.13 KB, patch)
2009-07-20 13:09 EDT, Paul Webster CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Paul Webster CLA 2009-07-10 15:04:23 EDT 
Variables from org.eclipse.ui.ISources have to be made available to the legacy handlers.

That means they need to be created in the fragment Workbench or fragment WorkbenchWindow.

PW
Comment 1 Remy Suen CLA 2009-07-15 08:06:13 EDT 
Added activeEditor support in PartsEventTransformer. It doesn't go back to null though. Also see bug 283246.
Comment 2 Paul Webster CLA 2009-07-15 13:49:28 EDT 
Added a few more activeEditor* variables and return the undefined object  from LegacyEvalContext

PW
Comment 3 Remy Suen CLA 2009-07-16 05:39:09 EDT 
We can't do 'Show In > Navigator' because showInSelection and showInInput is missing.
Comment 4 Paul Webster CLA 2009-07-16 11:28:51 EDT 
Created attachment 141795 [details]
Legacy handler service and show in v01

This updates the context the LegacyHandlerService deals with, so that the showIn input and selection are available.

This still involves querying a source provider, as show in is only calculated in very specific circumstances.

PW
Comment 5 Paul Webster CLA 2009-07-16 11:29:39 EDT 
(In reply to comment #4)
> Created an attachment (id=141795) [details]
> Legacy handler service and show in v01

Released for I20090716-1930
PW
Comment 6 Paul Webster CLA 2009-07-17 14:31:00 EDT 
Created attachment 141910 [details]
active menu variables v01
Comment 7 Paul Webster CLA 2009-07-20 13:09:55 EDT 
Created attachment 142048 [details]
active menu variables v02

Make them available at the Workbench level
Comment 8 Paul Webster CLA 2009-07-20 13:11:27 EDT 
(In reply to comment #7)
> Created an attachment (id=142048) [details]
> active menu variables v02

Released for I20090720-1930
PW
Comment 9 Paul Webster CLA 2009-07-22 15:02:45 EDT 
Added ACTIVE_FOCUS_CONTROL_ID_NAME and ACTIVE_FOCUS_CONTROL_NAME.
PW
Comment 10 Paul Webster CLA 2009-07-26 11:04:29 EDT 
in RC2
PW