Community
Participate
Working Groups
When selecting a branding or entrypoint we currently offer a list based on all plugins in the workspace. We should rather only show brandings/entrypoints from the selected bundles or vice-versa warn the user if he selected something that is not included in the selected bundles.
Created attachment 177520 [details] Validation for entrypoint/servletname Validating the selected EntryPoint against the extensions for Application and EntryPoint and the Servlet Name against the Branding extensions.
Created attachment 177833 [details] Validation entrypoint/servletname Changed the validation since there were problems with duplicated entrypoint names and servlet names. Now, validation will be successful on entrypoints if one of the selected bundles contains an entrypoint with the specified name and servlet names if one of the selected bundles contains a branding extension with the specified servlet name. Also added tests for duplicated servlet and entrypoint.
Hey Artur, I reviewed your patch. Looks good from a short look. But here are some drawbacks: - You use Java 1.5 api. We should only use Java 1.4. So, the code's not compiling. - There is a strange pattern in RAPLaunchConfigValidator. You have two loops. The count variable from the outer loop is called j and the inner i. These two should be reversed. - There are some really long methods e.g. RAPLaunchConfigValidator#getEntryPointExtensionForName. I think you should refactor them to have more shorter and meaningful methods. Really good that you found the solution with ILaunchConfigurationListener. It's nice to have a non internal way to get changes from the bundles tab without a dependency to it. When your code compiles on my machine (Java 1.4) I will test if it's working ;)
Created attachment 178913 [details] Patch to validate servlet name and entrypoint Refactored and compiling with Java 1.4.2 now.
Created attachment 178915 [details] Validation Entrypoint/Servletname Forgot about the weird pattern. Applied the changes to this patch.
Created attachment 189351 [details] Validation Entrypoint/Servletname I changed the way how validation works because there are new APIs which can be used. Patch was tested with Eclipse 3.6 and 3.7. I think this is a good feature for our luncher. Good work Artur!
The changes harm our coding conventions. Please follow the the conventions when you attach a patch. See http://wiki.eclipse.org/RAP/CodingConventions for more detailed information.
If this change requires specific versions, it should be reflected in the bundle dependencies.
Created attachment 189684 [details] Validation Entrypoint/Serveltname v2 I updated the formatting. Most of the problem occur because the convention '80 characters per line is maximum'. It is a little bit hart :) comment 8: Rüdiger I don't use any specific APIs. There are new utilities which I implemented for bug 323702. My use of the word APIs was wrong.
I committed your patch to CVS HEAD with some small changes. I did a little formattitng and changes some message. I also refactored some methods and did some naming.
