Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 282898 - [CSS] ETabFolder should support background color behind tab area
Summary: [CSS] ETabFolder should support background color behind tab area
Status: RESOLVED FIXED
Alias: None
Product: e4
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 0.9   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 0.9 RC1   Edit
Assignee: Kevin McGuire CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 282575
Blocks:
  Show dependency tree
 
Reported: 2009-07-08 13:51 EDT by Kevin McGuire CLA
Modified: 2009-07-17 14:54 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kevin McGuire CLA 2009-07-08 13:51:13 EDT 
Presently in CTabFolder, the unselected tab and the background color of the tab area are the same.  We want them to be different.

Not sure what property to use in CSS to support this, since background-color is presently used for the tabs themselves.

One idea would be to make CTabItem be the element which supports
  color
  background-color
 :selected

This would leave CTabFolder to interpret background color as the area behind the tabs.
Comment 1 Kevin McGuire CLA 2009-07-11 18:08:59 EDT 
I've added the color to the ETabFolder, released.

I've left ETabFolder.setBackground() as the way to set this.  I've introduced a new color field unselectedTabColor.  It still needs accessors and CSS.
Comment 2 Kevin McGuire CLA 2009-07-11 18:14:46 EDT 
See also bug #282905 comment #2 for a new styling capability if we had CSS for both bugs.
Comment 3 Kevin McGuire CLA 2009-07-12 11:24:38 EDT 
Would like to add CSS for RC1
Comment 4 Kevin McGuire CLA 2009-07-15 17:18:41 EDT 
Needs bug #282575 so can differentiate setting ETabFolder from ETabItem background color.
Comment 5 Kevin McGuire CLA 2009-07-15 17:48:53 EDT 
Released changes for background handler, and webby.css (legacy workbench).

Need to go through the two examples to see if they need to be changed to match change in semantics.
Comment 6 Kevin McGuire CLA 2009-07-15 17:50:22 EDT 
Note: webby.css now matches and expresses mockup wrt. tab coloring (but not keylines, separate bug).
Comment 7 Kevin McGuire CLA 2009-07-17 14:54:48 EDT 
Released as part of another bug, closing as fixed.