Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 282777 - [About] Feature tooltip and AccessibleListener should return feature label, not provider
Summary: [About] Feature tooltip and AccessibleListener should return feature label, n...
Status: CLOSED DUPLICATE of bug 198941
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.6   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Susan McCourt CLA
QA Contact: Susan McCourt CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-07-08 02:21 EDT by Philipp Kursawe CLA
Modified: 2009-09-28 18:01 EDT (History)
1 user (show)

See Also:


Attachments
Screenshot of buttons in about dialog (41.50 KB, image/png)
2009-09-28 15:19 EDT, Philipp Kursawe CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Philipp Kursawe CLA 2009-07-08 02:21:16 EDT
What use has it if I have all features of the same provider and the tooltips and accessibility feature return this provider? It would be much better to have the tooltip display the Label property of the feature and the accessibility adapter grab the tooltip of the button.
Comment 1 Chris Goldthorpe CLA 2009-07-14 11:36:41 EDT
Reassigning to Platform UI
Comment 2 Susan McCourt CLA 2009-07-14 12:00:38 EDT
will look at this for 3.6
Comment 3 Susan McCourt CLA 2009-09-28 14:19:38 EDT
(In reply to comment #0)
> What use has it if I have all features of the same provider and the tooltips
> and accessibility feature return this provider? 

I'm not sure what you are referring to.  I assumed you mean the "About Eclipse SDK Features" dialog?  That you get when you push a provider button in the about or dialog, or when you choose Installation Details>Features?  The only tooltip here is for columns whose content doesn't show (provider, name, version, id).  What am I misunderstanding?

> It would be much better to have
> the tooltip display the Label property of the feature and the accessibility
> adapter grab the tooltip of the button.

Which button?
I think I'm misinterpreting this bug.
Comment 4 Philipp Kursawe CLA 2009-09-28 15:19:16 EDT
Created attachment 148269 [details]
Screenshot of buttons in about dialog
Comment 5 Susan McCourt CLA 2009-09-28 17:43:54 EDT
Indeed, I was assuming you were discussing the features page, not the main about dialog.

Those buttons on the main dialog represent branded groups of bundles, not individual features.  They are distinguished by having unique provider names/graphics.  Pushing the button shows you all of the features that are included for that provider.  So I think the tooltip is correct in showing the provider name, as pushing that button will show all features provided by that provider.  

I would be surprised if the tooltip for each of the icons in your screenshot were the same.  I assume you see "Eclipse Modeling Framework", "Eclipse.org", "Findbugs", etc.  It's possible that a branding bundle with a unique branding graphic uses a generic provider (Eclipse.org), though I believe most of the branding bundles are moving away from that.

In my installation, I see 4 branding icons, whose tooltips are Eclipse Modeling Framework, Eclipse.org, Eclipse Web Tools Platform, and Eclipse.org (where the last icon looks like a wtp icon but says "Eclipse.org.")  That last one seems odd, I believe this to be a packaging/metadata issue with the WTP feature.

Closing this bug as "Invalid" as I believe that the dialog is doing the right thing, but there could be a specific metadata issue that should opened against those branding graphics that seem to have incorrect providers.
Comment 6 Susan McCourt CLA 2009-09-28 18:01:00 EDT
Just found a duplicate bug with a more detailed discussion and pointers to the planning council discussion.  This is indeed an issue with the branding plugin metadata that providers are expected to fix.  See bug 198941.

*** This bug has been marked as a duplicate of bug 198941 ***