Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 282672 - [plug-in registry] extension point to easily provide different connection providers
Summary: [plug-in registry] extension point to easily provide different connection pro...
Status: RESOLVED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: Incubators (show other bugs)
Version: 3.5   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Wojciech Galanciak CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-07-07 09:37 EDT by Jacek Pospychala CLA
Modified: 2009-07-10 03:34 EDT (History)
1 user (show)

See Also:

Attachments
extension point (4.79 KB, patch)
2009-07-09 05:50 EDT, Wojciech Galanciak CLA 		jacek.pospychala: iplog+
Details | Diff
RegistryModelFactory (2.31 KB, patch)
2009-07-09 07:50 EDT, Wojciech Galanciak CLA 		no flags Details | Diff
updated factory (2.50 KB, patch)
2009-07-09 10:51 EDT, Wojciech Galanciak CLA 		no flags Details | Diff
Wojtek patch "updated factory" with minor improvements (2.60 KB, patch)
2009-07-10 03:32 EDT, Jacek Pospychala CLA 		jacek.pospychala: iplog+
Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jacek Pospychala CLA 2009-07-07 09:37:55 EDT 
We need extension point to add providers for ECF, JMX, etc. backed models, because they all will bring new dependencies that whole pde.runtime plug-in cannot include.
Comment 1 Wojciech Galanciak CLA 2009-07-09 05:50:21 EDT 
Created attachment 141181 [details]
extension point

It adds extension point to org.eclipse.pde.runtime which allows to separate all implementations of remote communications (e.g. see 274982 bug).
Comment 2 Jacek Pospychala CLA 2009-07-09 06:17:50 EDT 
Wojtek, patch seems to miss something in plugin.xml. Doesn't apply cleanly.
Comment 3 Jacek Pospychala CLA 2009-07-09 06:46:56 EDT 
Ok, don't know why it didn't worked when I copied patch to clipboard. But patch saved to file works. Great work Wojciech!

FIXED in incubator.
Comment 4 Jacek Pospychala CLA 2009-07-09 06:57:05 EDT 
btw. we'll still need the correct code in RegistryModelFactory to make real use out of this newly added ext point. Pls attach the patch that does that to this bug once you separate it from patch to bug 282804.
Comment 5 Wojciech Galanciak CLA 2009-07-09 07:50:57 EDT 
Created attachment 141191 [details]
RegistryModelFactory

There is the patch with correct RegistryModelFactory class.
Comment 6 Wojciech Galanciak CLA 2009-07-09 10:51:52 EDT 
Created attachment 141210 [details]
updated factory

Now it works well with patch for bug 282804.
Comment 7 Jacek Pospychala CLA 2009-07-10 03:32:46 EDT 
Created attachment 141268 [details]
Wojtek patch "updated factory" with minor improvements

I removed unused constants (REMOTE and R-OSGI), removed call to unknown method RegistryBackend.setURI(). Also fixed a bit the javadoc, but it could be better.
Comment 8 Jacek Pospychala CLA 2009-07-10 03:34:48 EDT 
FIXED