Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 282281 - Allow no dependencies
Summary: Allow no dependencies
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Dash Athena (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Common Build Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-07-02 08:31 EDT by Gunnar Wagenknecht CLA
Modified: 2012-01-30 11:31 EST (History)
2 users (show)

See Also:
nboldt: iplog+

Attachments
patch (11.03 KB, patch)
2009-07-02 08:31 EDT, Gunnar Wagenknecht CLA 		no flags Details | Diff
alternative patch (883 bytes, patch)
2009-07-02 08:34 EDT, Gunnar Wagenknecht CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gunnar Wagenknecht CLA 2009-07-02 08:31:06 EDT 
I wonder if it makes sense to allow running the builder without setting property dependenciesURLs.

If it isn't set at all the build fails because of an invalid protocol.
Comment 1 Gunnar Wagenknecht CLA 2009-07-02 08:31:49 EDT 
Created attachment 140687 [details]
patch

The attached patch wraps the for loop into an if clause to only run if the property is set.
Comment 2 Gunnar Wagenknecht CLA 2009-07-02 08:34:05 EDT 
Created attachment 140688 [details]
alternative patch

This patch simply sets a default.
Comment 3 Gunnar Wagenknecht CLA 2009-07-02 08:35:22 EDT 
Comment on attachment 140687 [details]
patch

I noticed that this patch is to noisy because of line endings changes done by the Ant editor. I also think the alternative patch is a better way to go.
Comment 4 Nick Boldt CLA 2009-07-24 16:34:11 EDT 
Well, you still need a base eclipse runtime from which to run the build, but sure, this patch is accepted.