Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 282265 - [design] Buttons with CHECK and RADIO are not vertically centered
Summary: [design] Buttons with CHECK and RADIO are not vertically centered
Status: RESOLVED FIXED
Alias: None
Product: RAP
Classification: RT
Component: RWT (show other bugs)
Version: 1.2   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 1.3 M1   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-07-02 05:04 EDT by Rüdiger Herrmann CLA
Modified: 2009-08-04 15:54 EDT (History)
1 user (show)

See Also:

Attachments
Proposed patch (6.56 KB, patch)
2009-07-03 10:53 EDT, Asen Draganov CLA 		no flags Details | Diff
Proposed patch (10.25 KB, patch)
2009-07-07 03:55 EDT, Asen Draganov CLA 		no flags Details | Diff
Proposed patch (7.42 KB, patch)
2009-07-20 04:01 EDT, Asen Draganov CLA 		rsternberg: iplog+
Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Rüdiger Herrmann CLA 2009-07-02 05:04:36 EDT 
The business.css from org.eclipse.rap.design.example changes the appearance of CHECK and RADIO buttons.
With this change, they are not centered vertically anymore. 
With the default theme, the buttons are centered correctly.
Comment 1 Asen Draganov CLA 2009-07-03 10:53:49 EDT 
Created attachment 140777 [details]
Proposed patch
Comment 2 Rüdiger Herrmann CLA 2009-07-06 08:34:52 EDT 
Applied patch to  CVS HEAD.
Comment 3 Rüdiger Herrmann CLA 2009-07-06 17:44:33 EDT 
The patch breaks Button_Test
Comment 4 Asen Draganov CLA 2009-07-07 03:55:06 EDT 
Created attachment 140935 [details]
Proposed patch

The problem was caused by both paddings, that should be used in Check and Radio buttons. Some new things were introduced in the theming, in order to solve this issue. Button_Test is not changed. It runs without problems now.
Comment 5 Asen Draganov CLA 2009-07-07 04:09:44 EDT 
In the above comment I mean spacings, not paddings.
Comment 6 Asen Draganov CLA 2009-07-20 04:01:27 EDT 
Created attachment 141983 [details]
Proposed patch

Please, use this version of the patch.
Comment 7 Ralf Sternberg CLA 2009-07-21 06:47:09 EDT 
Applied patch to CVS with minor changes