Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 281959 - [All] Classes commonly used by diagrams should be put in org.eclipse.papyrus.diagram.common
Summary: [All] Classes commonly used by diagrams should be put in org.eclipse.papyrus....
Status: RESOLVED FIXED
Alias: None
Product: Papyrus
Classification: Modeling
Component: Core (show other bugs)
Version: 0.7.0   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Yann Tanguy CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-06-30 04:11 EDT by Yann Tanguy CLA
Modified: 2010-06-08 16:09 EDT (History)
2 users (show)

See Also:

Attachments
mylyn/context/zip (5.58 KB, application/octet-stream)
2009-06-30 04:20 EDT, Yann Tanguy CLA 		no flags Details
mylyn/context/zip (6.17 KB, application/octet-stream)
2009-06-30 11:47 EDT, Yann Tanguy CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yann Tanguy CLA 2009-06-30 04:11:02 EDT 
The following classes should be in common (not copied in diagram plug-ins):
org.eclipse.papyrus.diagram.clazz.custom.listeners.DropTargetListener
org.eclipse.papyrus.diagram.clazz.custom.parsers.AppliedStereotypeParser
Comment 1 Yann Tanguy CLA 2009-06-30 04:20:34 EDT 
New packages are:
org.eclipse.papyrus.diagram.common.listeners.DropTargetListener
org.eclipse.papyrus.diagram.common.parser.custom.AppliedStereotypeParser

AppliedStereotypeParser is referenced by GMFGen models -> should be corrected

(committed in r362)
Comment 2 Yann Tanguy CLA 2009-06-30 04:20:36 EDT 
Created attachment 140463 [details]
mylyn/context/zip
Comment 3 Yann Tanguy CLA 2009-06-30 04:23:43 EDT 
AppliedStereotypeParser appears twice:
org.eclipse.papyrus.diagram.common.parser.custom.AppliedStereotypeParser
org.eclipse.papyrus.diagram.common.parser.stereotype.AppliedStereotypeParser
Comment 4 Yann Tanguy CLA 2009-06-30 11:30:41 EDT 
org.eclipse.papyrus.diagram.clazz.custom.policies.RemoveOrphanViewPolicy

Moved to :

org.eclipse.papyrus.diagram.common.editpolicies.RemoveOrphanViewPolicy

Generated classes in Class diagram updated in order to avoid compilation issues but the GMFGen still requires to be fixed in order to reference RemoveOrphanViewPolicy correctly. --> Action Patrick

(r366)
Comment 5 Yann Tanguy CLA 2009-06-30 11:47:30 EDT 
RemoveOrphanViewPolicy uses VisualID specific to the ClassDiagram --> should not be in common (rollback commit (r366))

Equivalent classes should be created for each diagram with VisualID specific to each of them...

The best solution would be to generate this class not to create it manually.
Comment 6 Yann Tanguy CLA 2009-06-30 11:47:33 EDT 
Created attachment 140513 [details]
mylyn/context/zip
Comment 7 Yann Tanguy CLA 2010-06-08 16:09:35 EDT 
Not relevant anymore.