Community
Participate
Working Groups
1. Open the 'Outline' view (it should be open already). 2. Open the 'Ant' view. It should open in the same stack as the 'Outline' view. 3. Notice that the toolbar has completely eaten up the stack's tabs. 4. Increase the size of that stack horizontally and the tabs will show up.
This is the result of not having (yet) duplicated the mechanism used in the 3.x stream to do this. There the PaneFolder is actually managing two controls; - a CTabFolder: manages the tabs and min/max affordance and the toolbar if there's enough space) - a ViewForm: manages the 'message area' and the Toolbar if it won't fit into CTabFolder's top-right area. This is a somewhat complicated dance between the two controls. Since they're both 'custom' perhaps we can provide a new custom control that combines the capabilities of both (i.e. create a subclass of CTabFolder that can manage the message area and have complete control of the Toolbar location).
(In reply to comment #1) > This is a somewhat complicated dance between the two controls. Since they're > both 'custom' perhaps we can provide a new custom control that combines the > capabilities of both (i.e. create a subclass of CTabFolder that can manage the > message area and have complete control of the Toolbar location). +1
Maybe someone from the SWT team can help us with this?
Interestingly this hasn't been reported by anyone as a major defect. At this point trying to provide an implementation for this that matches 3.x would likely jeopardize the release date...
Note that it's one of the first issues I think we should address since it can really affect the usability of the view stacks.
While we may have to drop this, I think it should be considered for 4.0. Almost any use of the same stack that has the package explorer renders the view tabs in that stack unreadable. PW
*** Bug 317456 has been marked as a duplicate of this bug. ***
(In reply to comment #4) > Interestingly this hasn't been reported by anyone as a major defect. Now it is: bug 317456 :-). A agree with Paul, while not a ship stopper, this is a major eyesore.
Yep, this is the result of the legacy code using a mashed together combination of a CTabItem's control actually being a ViewForm and a whole bunch of wiring... My sincere hope is that we can address this by augmenting the CTF's behavior to provide this functionality (as well as the 'message area'). Note that we couldn't do this because we couldn't change the CTF's API for 3.6.
(In reply to comment #4) > Interestingly this hasn't been reported by anyone as a major defect. At this > point trying to provide an implementation for this that matches 3.x would > likely jeopardize the release date... This is also the subject of bug 314159. I didn't mark it a duplicate because it has some screenshots that show problematic scenarios and has a higher sev (it was on Dani's stop ship list as bug 318868). For views with lots of toolbars (such as synchronize) it nearly guarantees that you won't see a view title.
Created attachment 173715 [details] screenshot this screenshot shows how the toolbar itself can seemlingly "dangle" past the left border of the view stack.
This is fixed by Bogdan's CTabFolder changes. We can open new bugs for any remaining bugs/cheese/problems with the algorithm. > this screenshot shows how the toolbar itself can seemlingly "dangle" past the > left border of the view stack. This problem still exists and is now the focus of bug 314159
