Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 281372 - RCP Product Export wizard copies over wrong Mac icon to launcher
Summary: RCP Product Export wizard copies over wrong Mac icon to launcher
Status: RESOLVED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: Build (show other bugs)
Version: 3.5   Edit
Hardware: PC Windows Vista
: P3 normal (vote)
Target Milestone: 3.5.1   Edit
Assignee: pde-build-inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 291389 (view as bug list)
Depends on:
Blocks:
 
Reported: 2009-06-24 12:43 EDT by CLA
Modified: 2009-10-05 12:58 EDT (History)
3 users (show)

See Also:
dj.houghton: review+

Attachments
Product Info file (6.84 KB, application/xml)
2009-06-24 14:14 EDT, CLA 		no flags Details
patch (1.96 KB, patch)
2009-08-18 17:20 EDT, Andrew Niefer CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description CLA 2009-06-24 12:43:18 EDT 
Build ID:  I20090611-1540

Steps To Reproduce:
I have an RCP Product Export configuration containing the following:

   <launcher name="ReCourse">
      <linux icon="/org.tencompetence.ldauthor/branding/linux/ldauthor.xpm"/>
      <macosx icon="/org.tencompetence.ldauthor/branding/mac/ldauthor.icns"/>
      <solaris/>
      <win useIco="true">
         <ico path="/org.tencompetence.ldauthor/branding/windows/ldauthor.ico"/>
         <bmp/>
      </win>
   </launcher>

I launch the Product Export wizard and select "Export for multiple platforms" and then select linux (gtk/86), macosx (carbon/x86) and win32 (win32/x86).

I look in the exported folder for Mac and see in the ReCourse.app/Contents/Resources folder that the wrong icon has been copied:

ldauthor.xpm     <---- This is the linux icon!

When it should be:

ldauthor.icns    <----- Mac icon!

It's copied over the icon from the Linux configuration and also added the incorrect entry to the Info.plist file!

However, if I run the export wizard without choosing "Export for multiple platforms" it's OK.

This broke in 3.5





More information:
Comment 1 Andrew Niefer CLA 2009-06-24 14:02:38 EDT 
Are you exporting with metadata? ("Generate metadata repository")
Comment 2 CLA 2009-06-24 14:13:06 EDT 
(In reply to comment #1)
> Are you exporting with metadata? ("Generate metadata repository")
> 

I tried both options. Still the same result.
Comment 3 CLA 2009-06-24 14:14:55 EDT 
Created attachment 140014 [details]
Product Info file

Attached Product Info file fore reference.
Comment 4 Andrew Niefer CLA 2009-06-24 14:19:56 EDT 
Ok, I see the problem.

This is a consequence the change we made to run one multi-platform build instead of N single platform builds.

Branding is done using a list of icons:
icons = ${launcherIcons}, iconA, iconB
The list depends on the platform, except ${launcherIcons} goes first.
UI sets launcherIcons to be the full set for all platforms.

The branding iron itself is just using icons[0] on the platforms that only use 1 icon.

If you aren't using metadata, workaround is to do one platform at a time.  If you are using metadata, you could still do that, except the resulting metadata wouldn't be multi-platform and you couldn't use the same repo to update all platforms.

Possible fixes are 
1) put ${launcherIcons} at the end of the list instead of the beginning
2) make the branding iron smarter, we are lucky enough that the different platforms all use different extensions for their icons.
Comment 5 Andrew Niefer CLA 2009-08-18 17:20:55 EDT 
Created attachment 144884 [details]
patch
Comment 6 Andrew Niefer CLA 2009-08-18 17:29:41 EDT 
DJ can you please review
Comment 7 DJ Houghton CLA 2009-08-19 15:22:38 EDT 
Released.
Comment 8 Andrew Niefer CLA 2009-10-05 12:58:12 EDT 
*** Bug 291389 has been marked as a duplicate of this bug. ***