Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 280376 - discovery element twice the size of others
Summary: discovery element twice the size of others
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows Vista
: P3 minor (vote)
Target Milestone: 3.2   Edit
Assignee: Steffen Pingel CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 272621
  Show dependency tree
 
Reported: 2009-06-15 22:11 EDT by Shawn Minto CLA
Modified: 2009-06-16 17:24 EDT (History)
1 user (show)

See Also:


Attachments
screenshot (78.78 KB, image/png)
2009-06-15 22:12 EDT, Shawn Minto CLA
no flags Details
fix (1.82 KB, patch)
2009-06-16 04:10 EDT, Steffen Pingel CLA
no flags Details | Diff
updated patch (2.91 KB, patch)
2009-06-16 16:59 EDT, Steffen Pingel CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Shawn Minto CLA 2009-06-15 22:11:36 EDT
I have one element in my discovery listing that is always really large.  I am unsure of what this could be, but it could be a windows 7 issue as well.
Comment 1 Shawn Minto CLA 2009-06-15 22:12:32 EDT
Created attachment 139240 [details]
screenshot
Comment 2 David Green CLA 2009-06-16 00:16:38 EDT
I can't reproduce this problem with the public discovery directory.  I don't have access to the problem discovery content.  Can you please provide me with the problem listing?
Comment 3 Steffen Pingel CLA 2009-06-16 01:11:52 EDT
I'll send it to you via email. I have not seen this on Linux but can reproduce it on Windows Vista.
Comment 4 David Green CLA 2009-06-16 01:53:18 EDT
Looks fine on mac.  I can look into this one late tomorrow.  Steffen, Shawn feel free to investigate further if you get the chance.
Comment 5 Steffen Pingel CLA 2009-06-16 02:06:40 EDT
As a work-around it might work to make the dialog just slightly wider (or change the text). David, could you point me at the code that sets the size constraints for the wizard? I wasn't able to find it.
Comment 6 Steffen Pingel CLA 2009-06-16 04:10:43 EDT
Created attachment 139260 [details]
fix

I believe the problem is caused by controls without labels that (sometimes) advertise their default size (64x64) hence reserving blank space. I have tested the patch on Vista and Gtk. David, can you verify on Mac and commit?

I noticed that the last entry of the listing is cut off on Vista and Gtk but that is probably a separate problem.
Comment 7 Steffen Pingel CLA 2009-06-16 04:18:29 EDT
Might explain the cut off element on the bottom:  http://stackoverflow.com/questions/35123/prevent-swt-scrolledcomposite-from-eating-part-of-its-children
Comment 8 Shawn Minto CLA 2009-06-16 11:29:03 EDT
Good find steffen!
Comment 9 David Green CLA 2009-06-16 15:13:29 EDT
(In reply to comment #6)
> I believe the problem is caused by controls without labels that (sometimes)
> advertise their default size (64x64) hence reserving blank space. I have tested
> the patch on Vista and Gtk. David, can you verify on Mac and commit?

Nice patch.  Why are you providing strings with a space?  Would an empty string suffice?  On the checkbox the extra space has an adverse effect on layout.
Can you try your patch again using empty strings instead?

(In reply to comment #7)
> Might explain the cut off element on the bottom:
> http://stackoverflow.com/questions/35123/prevent-swt-scrolledcomposite-from-eating-part-of-its-children

Nice find!   Makes sense to me.
Comment 10 Steffen Pingel CLA 2009-06-16 16:59:01 EDT
Created attachment 139368 [details]
updated patch
Comment 11 Steffen Pingel CLA 2009-06-16 17:24:09 EDT
I have committed the patch. Unfortunately empty labels will trigger the SWT layout weirdness but we have reduced the spacing slightly to offset the label. I have also added another work-around for the cut off entry at the end of the listing.