This Bugzilla instance is deprecated, and most Eclipse projects now use GitHub or Eclipse GitLab. Please see the deprecation plan for details.
Bug 280094 - HTMLAttributeValidator#validate should use model query extensions
Summary: HTMLAttributeValidator#validate should use model query extensions
Status: RESOLVED FIXED
Alias: None
Product: WTP Source Editing
Classification: WebTools
Component: wst.html (show other bugs)
Version: 3.1   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.2 M1   Edit
Assignee: Dan Lee CLA
QA Contact: Nitin Dahyabhai CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-06-12 11:07 EDT by Dan Lee CLA
Modified: 2009-07-23 09:18 EDT (History)
0 users

See Also:
thatnitind: review+

Attachments
Patch file attached. (1.98 KB, patch)
2009-06-12 13:16 EDT, Dan Lee CLA 		no flags Details | Diff
Patch file attached. (1.98 KB, patch)
2009-06-12 13:16 EDT, Dan Lee CLA 		thatnitind: iplog+
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dan Lee CLA 2009-06-12 11:07:03 EDT 
Build ID: Ganymede

Steps To Reproduce:
The HTMLAttributeValidator#validate method does not use the Model Query Extension Points when determining if an attribute value is valid, if that attribute is also defined in a DTD. This method should query both the DTD and the Model Query Extensions for candidate values, and then merge the result sets of each of these queries.

I have attached a patch that uses a HashSet to do this result set merge.

More information:
Comment 1 Nitin Dahyabhai CLA 2009-06-12 13:12:41 EDT 
Hmmm, no you haven't...
Comment 2 Dan Lee CLA 2009-06-12 13:16:39 EDT 
Created attachment 139048 [details]
Patch file attached.

Attachment attempt Number 2!
Comment 3 Dan Lee CLA 2009-06-12 13:16:52 EDT 
Created attachment 139049 [details]
Patch file attached.

Attachment attempt Number 2!
Comment 4 Dan Lee CLA 2009-06-12 13:23:00 EDT 
Ha, there. Now you have two patches to choose from. :)

(They are identical, chalk this up to general bugzilla ineptitude).
Comment 5 Nitin Dahyabhai CLA 2009-07-22 17:32:22 EDT 
Applied, thanks, Dan!
Comment 6 Nitin Dahyabhai CLA 2009-07-23 09:14:44 EDT 
Reopening due to unit test failure.
Comment 7 Nitin Dahyabhai CLA 2009-07-23 09:18:06 EDT 
Altered test of enumerated values to only be performed when CMDataType.ENUM.equals(attrType.getDataTypeName()).